From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Tom Herbert <therbert@google.com>,
Neal Cardwell <ncardwell@google.com>,
Hagen Paul Pfeifer <hagen@jauu.net>
Subject: Re: [PATCH net-next] netem: add ECN capability
Date: Tue, 01 May 2012 19:10:44 +0200 [thread overview]
Message-ID: <1335892244.22133.27.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120501095914.0e60ff6a@s6510.linuxnetplumber.net>
On Tue, 2012-05-01 at 09:59 -0700, Stephen Hemminger wrote:
> The concept is fine, but a couple of questions.
> 1. Why a whole u32 for boolean?
a boolean in this structure wont save space, and this file is full of
u32. Why bother ?
IMHO boolean are fine for function arguments, but in a structure, not
very helpful.
> 2. The logic in this part of netem is setup to handle case of random duplication
> combined with random loss. With ecn option set, will this code correctly
> handled a duplication combined with a loss and send one packet?
> It looks like the new code would change that behaviour.
Hmm, I'll take a look.
prev parent reply other threads:[~2012-05-01 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 9:11 [PATCH net-next] netem: add ECN capability Eric Dumazet
2012-05-01 9:28 ` Hagen Paul Pfeifer
2012-05-01 10:14 ` Dave Taht
2012-05-01 13:40 ` David Miller
2012-05-01 16:59 ` Stephen Hemminger
2012-05-01 17:17 ` David Miller
2012-05-01 18:49 ` Dave Taht
2012-05-01 19:13 ` David Miller
2012-05-01 16:59 ` Stephen Hemminger
2012-05-01 17:10 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335892244.22133.27.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hagen@jauu.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox