Re: [PATCH 2/2] tcp: cleanup tcp_try_coalesce

Alexander Duyck
2012-05-03T05:41:47Z

On 5/2/2012 10:19 PM, Eric Dumazet wrote:
> On Wed, 2012-05-02 at 21:58 -0700, Alexander Duyck wrote:
>> The question I have is how can you get into a case where the ksize is
>> different from the end offset plus the aligned size of skb_shared_info?
>> From what I can tell it looks like the only place we can lie is if we
>> use build_skb with the frag_size option, and in that case we are using a
>> page, not kmalloc memory. Otherwise in all other cases __alloc_skb or
>> build_skb is using ksize(skb->head) - SKB_DATA_ALIGN(struct
>> skb_shared_info) to set the end pointer, so reversing that should give
>> us the same value as ksize(skb->head).
>
> Right after skb is allocated (build_skb() or other skb_alloc...
> variants), truesize is correct by construction.
>
> Then drivers add fragments and can make truesize smaller than reality.
>
> And Intel drivers are known to abuse truesize.
>
> My last patch against iwlwifi is still waiting to make its way into
> official tree.
>
> http://www.spinics.net/lists/netdev/msg192629.html
I think the part that has me confused is how being more precise about
removing from truesize gets in the way of detecting abuses of truesize.
It seems like it should be more as good as or better then the original
approach of just using skb->len.

Then again we might just be talking in circles again. I have things
broken out into 3 patches now that are much more readable. I will email
them out in an hour or so once I do some quick tests to verify they are
building and don't break anything.

Thanks,

Alex