Re: [PATCH 2/2] tcp: cleanup tcp_try_coalesce

Guy, Wey-Yi
2012-05-03T20:21:12Z

Hi John,

On Thu, 2012-05-03 at 13:07 -0400, John W. Linville wrote:
> On Thu, May 03, 2012 at 08:24:19AM -0700, Guy, Wey-Yi wrote:
> > Hi John,
> >
> > On Thu, 2012-05-03 at 11:14 -0400, John W. Linville wrote:
> > > On Thu, May 03, 2012 at 01:25:02AM -0400, David Miller wrote:
> > > > From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > > Date: Thu, 03 May 2012 07:19:33 +0200
> > > >
> > > > > My last patch against iwlwifi is still waiting to make its way into
> > > > > official tree.
> > > > >
> > > > > http://www.spinics.net/lists/netdev/msg192629.html
> > > >
> > > > John, please rectify this situation.
> > > >
> > > > The Intel Wireless folks said they would test it, but that was more
> > > > than a month ago.
> > > >
> > > > It's not acceptable to let bug fixes rot for that long, I don't care
> > > > what their special internal testing procedure is.
> > > >
> > > > If they give you further pushback, please just ignore them and apply
> > > > Eric's fix directly.
> > > >
> > > > Thank you.
> > >
> > > I imagine that this somehow got lost in the shuffle during the
> > > merge window. That doesn't excuse it, of course.
> > >
> > > It has waited long enough already, so I'll just go ahead and take it.
> > >
> > it is my mistake to lost this patch during the iwlwifi re-factor work,
> > the patch is no longer apply and I ask Eric to rebase the patch.
> >
> > Sorry again for the mistake
>
> Well, it seems like a fix needed for 3.4. And, the patch applies there.
>
> It does cause some merge breakage in wireless-testing (and presumably
> in linux-next). I'll attach the commit diff for the wireless-testing
> merge fixup I did, for review and/or as a peace offering to sfr... :-)
>
> Please take a look at the result in wireless-testing and let me know
> if it is broken...thanks!
>
Looks good to me, thanks very much for helping this.

Wey

>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html