From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 7/9] net: add skb_orphan_frags to copy aside frags with destructors Date: Fri, 4 May 2012 11:51:31 +0100 Message-ID: <1336128691.2361.54.camel@zakaz.uk.xensource.com> References: <20120503154142.GB27671@redhat.com> <20120503.135532.1038384417514973419.davem@davemloft.net> <20120503210826.GA30504@redhat.com> <20120504.025433.1474691040952890731.davem@davemloft.net> <20120504100310.GB31083@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Miller , "netdev@vger.kernel.org" , "eric.dumazet@gmail.com" To: "Michael S. Tsirkin" Return-path: Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:51026 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754910Ab2EDKve (ORCPT ); Fri, 4 May 2012 06:51:34 -0400 In-Reply-To: <20120504100310.GB31083@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2012-05-04 at 11:03 +0100, Michael S. Tsirkin wrote: > On Fri, May 04, 2012 at 02:54:33AM -0400, David Miller wrote: > > From: "Michael S. Tsirkin" > > Date: Fri, 4 May 2012 00:10:24 +0300 > > > > > Hmm we orphan skbs when we loop them back so how about reusing the > > > skb->destructor for this? > > > > That's one possibility. > > > > But I fear we're about to toss Ian into yet another rabbit hole. :-) > > > > Let's try to converge on something quickly as I think integration of > > his work has been delayed enough as-is. > > This is more intrusive than I'd like because on > error we need to free the skb, so need > to return error code from orphan, but it does not add > an extra branch since skb_orphan is inline. > So intrusive but should not hurt fast path. > > It's weekend here, I'll work on a patch like this > Sunday. Thanks, I was starting to feel my nose twitching and my ears beginning to elongate ;-) Ian.