From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: skb_peek()/skb_peek_tail() cleanups
Date: Fri, 04 May 2012 15:01:31 +0200 [thread overview]
Message-ID: <1336136491.3752.318.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120501.094127.190023878792795840.davem@davemloft.net>
On Tue, 2012-05-01 at 09:41 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 01 May 2012 04:31:46 +0200
>
> > From: Eric Dumazet <edumazet@google.com>
> >
> > remove useless casts and rename variables for less confusion.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Applied, I really need to get back to completing the list_head
> conversion :-/
Actually doubly linked lists everywhere has a performance issue.
When we dequeue one skb, we must bring in cpu cache the next skb as
well, to perform the unlink.
In some places it would be better to not have a double linked list, and
only perform a prefetch(skb->next).
next prev parent reply other threads:[~2012-05-04 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 2:31 [PATCH net-next] net: skb_peek()/skb_peek_tail() cleanups Eric Dumazet
2012-05-01 13:41 ` David Miller
2012-05-04 13:01 ` Eric Dumazet [this message]
2012-05-04 14:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336136491.3752.318.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox