From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH 3/3] skb: Add inline helper for getting the skb end offset from head
Date: Sat, 05 May 2012 07:39:21 +0200 [thread overview]
Message-ID: <1336196361.3752.485.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120505002656.21292.89799.stgit@gitlad.jf.intel.com>
On Fri, 2012-05-04 at 17:26 -0700, Alexander Duyck wrote:
> With the recent changes for how we compute the skb truesize it occurs to me
> we are probably going to have a lot of calls to skb_end_pointer -
> skb->head. Instead of running all over the place doing that it would make
> more sense to just make it a separate inline skb_end_offset(skb) that way
> we can return the correct value without having gcc having to do all the
> optimization to cancel out skb->head - skb->head.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
>
> drivers/atm/ambassador.c | 2 +-
> drivers/atm/idt77252.c | 2 +-
> drivers/net/wimax/i2400m/usb-rx.c | 2 +-
> drivers/staging/octeon/ethernet-tx.c | 2 +-
> include/linux/skbuff.h | 12 +++++++++++-
> net/core/skbuff.c | 12 ++++++------
> 6 files changed, 21 insertions(+), 11 deletions(-)
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2012-05-05 5:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 0:26 [PATCH 0/3] First pass of cleanups for pskb_expand_head Alexander Duyck
2012-05-05 0:26 ` [PATCH 1/3] skb: Drop bad code from pskb_expand_head Alexander Duyck
2012-05-05 5:35 ` Eric Dumazet
2012-05-06 17:13 ` David Miller
2012-05-05 0:26 ` [PATCH 2/3] skb: Drop "fastpath" variable for skb_cloned check in pskb_expand_head Alexander Duyck
2012-05-05 5:37 ` Eric Dumazet
2012-05-06 17:13 ` David Miller
2012-05-05 0:26 ` [PATCH 3/3] skb: Add inline helper for getting the skb end offset from head Alexander Duyck
2012-05-05 5:39 ` Eric Dumazet [this message]
2012-05-06 17:13 ` David Miller
2012-05-05 5:44 ` [PATCH 0/3] First pass of cleanups for pskb_expand_head Eric Dumazet
2012-05-05 6:51 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336196361.3752.485.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox