netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2011-01-22 11:56 Jeff Kirsher
  2011-01-24  8:19 ` Jeff Kirsher
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2011-01-22 11:56 UTC (permalink / raw)
  To: David Miller, davem; +Cc: Jeff Kirsher, netdev, gospo, bphilips

The following series contains cleanups for e1000e and addition support
for the i340 adapter in igb.

The following are changes since commit bb134d2298b49f50cf6d9388410fba96272905dc:
  net: netif_setup_tc() is static

and are available in the git repository at:
  master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/net-next-2.6 master

Bruce Allan (2):
  e1000e: reduce scope of some variables, remove unnecessary ones
  e1000e: Use kmemdup rather than duplicating its implementation

Carolyn Wyborny (1):
  igb: Add support for i340 Quad Port Fiber Adapter

Jeff Kirsher (1):
  e1000e: convert to stats64

 drivers/net/e1000e/e1000.h    |    5 ++-
 drivers/net/e1000e/ethtool.c  |   52 ++++++++-----------
 drivers/net/e1000e/ich8lan.c  |    3 +-
 drivers/net/e1000e/lib.c      |    4 +-
 drivers/net/e1000e/netdev.c   |  117 +++++++++++++++++++++++++++-------------
 drivers/net/e1000e/phy.c      |    8 ++--
 drivers/net/igb/e1000_82575.c |    1 +
 drivers/net/igb/e1000_hw.h    |    1 +
 drivers/net/igb/igb_main.c    |    1 +
 9 files changed, 116 insertions(+), 76 deletions(-)

-- 
1.7.3.4


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2011-01-22 11:56 Jeff Kirsher
@ 2011-01-24  8:19 ` Jeff Kirsher
  2011-01-24 21:02   ` David Miller
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2011-01-24  8:19 UTC (permalink / raw)
  To: David Miller; +Cc: Jeff Kirsher, netdev, gospo, bphilips

On Sat, Jan 22, 2011 at 03:56, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> The following series contains cleanups for e1000e and addition support
> for the i340 adapter in igb.
>
> The following are changes since commit bb134d2298b49f50cf6d9388410fba96272905dc:
>  net: netif_setup_tc() is static
>
> and are available in the git repository at:
>  master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/net-next-2.6 master
>
> Bruce Allan (2):
>  e1000e: reduce scope of some variables, remove unnecessary ones
>  e1000e: Use kmemdup rather than duplicating its implementation
>
> Carolyn Wyborny (1):
>  igb: Add support for i340 Quad Port Fiber Adapter
>
> Jeff Kirsher (1):
>  e1000e: convert to stats64
>

I have updated my tree to include Flavio's Signed-off-by on the following patch:

e1000e: convert to stats64

-- 
Cheers,
Jeff

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2011-01-24  8:19 ` Jeff Kirsher
@ 2011-01-24 21:02   ` David Miller
  0 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2011-01-24 21:02 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, bphilips

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 24 Jan 2011 00:19:30 -0800

> On Sat, Jan 22, 2011 at 03:56, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
>> The following series contains cleanups for e1000e and addition support
>> for the i340 adapter in igb.
>>
>> The following are changes since commit bb134d2298b49f50cf6d9388410fba96272905dc:
>>  net: netif_setup_tc() is static
>>
>> and are available in the git repository at:
>>  master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/net-next-2.6 master
>>
>> Bruce Allan (2):
>>  e1000e: reduce scope of some variables, remove unnecessary ones
>>  e1000e: Use kmemdup rather than duplicating its implementation
>>
>> Carolyn Wyborny (1):
>>  igb: Add support for i340 Quad Port Fiber Adapter
>>
>> Jeff Kirsher (1):
>>  e1000e: convert to stats64
>>
> 
> I have updated my tree to include Flavio's Signed-off-by on the following patch:
> 
> e1000e: convert to stats64

Pulled, thanks a lot Jeff.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2012-03-03  2:24 Jeff Kirsher
  2012-03-03  2:27 ` Jeff Kirsher
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2012-03-03  2:24 UTC (permalink / raw)
  To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann

This series of patches contains fixes e100 and DCB (ixgbe, bnx2x).

The following are changes since commit b4017c5368f992fb8fb3a2545a0977082c6664e4:
  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Ben Greear (2):
  e100: Fix rx-over-length statistics.
  e100: Show short v/s long rx length errors in ethtool stats.

John Fastabend (2):
  ixgbe: dcb: check setup_tc return codes
  net: dcb: getnumtcs()/setnumtcs() should return an int

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c |    4 +-
 drivers/net/ethernet/intel/e100.c               |    8 +++++-
 drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c |   30 +++++++++++++++-------
 include/net/dcbnl.h                             |    4 +-
 4 files changed, 31 insertions(+), 15 deletions(-)

-- 
1.7.7.6

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2012-03-03  2:26 Jeff Kirsher
  2012-03-03 19:53 ` David Miller
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2012-03-03  2:26 UTC (permalink / raw)
  To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann

This series of patches contains fixes e100 and DCB (ixgbe, bnx2x).

The following are changes since commit b4017c5368f992fb8fb3a2545a0977082c6664e4:
  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Ben Greear (2):
  e100: Fix rx-over-length statistics.
  e100: Show short v/s long rx length errors in ethtool stats.

John Fastabend (2):
  ixgbe: dcb: check setup_tc return codes
  net: dcb: getnumtcs()/setnumtcs() should return an int

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c |    4 +-
 drivers/net/ethernet/intel/e100.c               |    8 +++++-
 drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c |   30 +++++++++++++++-------
 include/net/dcbnl.h                             |    4 +-
 4 files changed, 31 insertions(+), 15 deletions(-)

-- 
1.7.7.6

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-03-03  2:24 Jeff Kirsher
@ 2012-03-03  2:27 ` Jeff Kirsher
  0 siblings, 0 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-03-03  2:27 UTC (permalink / raw)
  To: davem; +Cc: netdev, gospo, sassmann

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Fri, 2012-03-02 at 18:24 -0800, Jeff Kirsher wrote:
> This series of patches contains fixes e100 and DCB (ixgbe, bnx2x).
> 
> The following are changes since commit b4017c5368f992fb8fb3a2545a0977082c6664e4:
>   Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> 
> Ben Greear (2):
>   e100: Fix rx-over-length statistics.
>   e100: Show short v/s long rx length errors in ethtool stats.
> 
> John Fastabend (2):
>   ixgbe: dcb: check setup_tc return codes
>   net: dcb: getnumtcs()/setnumtcs() should return an int
> 
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c |    4 +-
>  drivers/net/ethernet/intel/e100.c               |    8 +++++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c |   30 +++++++++++++++-------
>  include/net/dcbnl.h                             |    4 +-
>  4 files changed, 31 insertions(+), 15 deletions(-)
> 

Please disregard this first pull request, patches from a previous pull
request were sent accidentally.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-03-03  2:26 Jeff Kirsher
@ 2012-03-03 19:53 ` David Miller
  0 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2012-03-03 19:53 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri,  2 Mar 2012 18:26:23 -0800

> This series of patches contains fixes e100 and DCB (ixgbe, bnx2x).
> 
> The following are changes since commit b4017c5368f992fb8fb3a2545a0977082c6664e4:
>   Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> 
> Ben Greear (2):
>   e100: Fix rx-over-length statistics.
>   e100: Show short v/s long rx length errors in ethtool stats.
> 
> John Fastabend (2):
>   ixgbe: dcb: check setup_tc return codes
>   net: dcb: getnumtcs()/setnumtcs() should return an int

Pulled, thanks.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2012-05-05 12:38 Jeff Kirsher
  2012-05-05 12:38 ` [net-next 1/4] e1000e: enable forced master/slave on 82577 Jeff Kirsher
                   ` (4 more replies)
  0 siblings, 5 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-05 12:38 UTC (permalink / raw)
  To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann

This series of patches contains updates for e1000e and ixgbe.

NOTE- The ixgbe patch can and probably should be applied to
David Miller's net tree as well.

The following are changes since commit bd14b1b2e29bd6812597f896dde06eaf7c6d2f24:
  tcp: be more strict before accepting ECN negociation
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Bruce Allan (2):
  e1000e: enable forced master/slave on 82577
  e1000e: increase version number

John Fastabend (1):
  ixgbe: dcb: IEEE PFC stats and reset logic incorrect

Richard Alpe (1):
  e1000e: clear REQ and GNT in EECD (82571 && 82572)

 drivers/net/ethernet/intel/e1000e/82571.c       |   12 ++++-
 drivers/net/ethernet/intel/e1000e/netdev.c      |    2 +-
 drivers/net/ethernet/intel/e1000e/phy.c         |   71 ++++++++++++++--------
 drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c |    7 ++
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c   |    6 ++-
 5 files changed, 69 insertions(+), 29 deletions(-)

-- 
1.7.7.6

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 1/4] e1000e: enable forced master/slave on 82577
  2012-05-05 12:38 [net-next 0/4][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
@ 2012-05-05 12:38 ` Jeff Kirsher
  2012-05-05 12:38 ` [net-next 2/4] e1000e: clear REQ and GNT in EECD (82571 && 82572) Jeff Kirsher
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-05 12:38 UTC (permalink / raw)
  To: davem; +Cc: Bruce Allan, netdev, gospo, sassmann, Jeff Kirsher

From: Bruce Allan <bruce.w.allan@intel.com>

Like other supported (igp) PHYs, the driver needs to be able to force the
master/slave mode on 82577.  Since the code is the same as what already
exists in the code flow for igp PHYs, move it to a new function to be
called for both flows.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/e1000e/phy.c |   71 +++++++++++++++++++-----------
 1 files changed, 45 insertions(+), 26 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c
index ada7133..0334d01 100644
--- a/drivers/net/ethernet/intel/e1000e/phy.c
+++ b/drivers/net/ethernet/intel/e1000e/phy.c
@@ -639,6 +639,45 @@ s32 e1000e_write_kmrn_reg_locked(struct e1000_hw *hw, u32 offset, u16 data)
 }
 
 /**
+ *  e1000_set_master_slave_mode - Setup PHY for Master/slave mode
+ *  @hw: pointer to the HW structure
+ *
+ *  Sets up Master/slave mode
+ **/
+static s32 e1000_set_master_slave_mode(struct e1000_hw *hw)
+{
+	s32 ret_val;
+	u16 phy_data;
+
+	/* Resolve Master/Slave mode */
+	ret_val = e1e_rphy(hw, PHY_1000T_CTRL, &phy_data);
+	if (ret_val)
+		return ret_val;
+
+	/* load defaults for future use */
+	hw->phy.original_ms_type = (phy_data & CR_1000T_MS_ENABLE) ?
+	    ((phy_data & CR_1000T_MS_VALUE) ?
+	     e1000_ms_force_master : e1000_ms_force_slave) : e1000_ms_auto;
+
+	switch (hw->phy.ms_type) {
+	case e1000_ms_force_master:
+		phy_data |= (CR_1000T_MS_ENABLE | CR_1000T_MS_VALUE);
+		break;
+	case e1000_ms_force_slave:
+		phy_data |= CR_1000T_MS_ENABLE;
+		phy_data &= ~(CR_1000T_MS_VALUE);
+		break;
+	case e1000_ms_auto:
+		phy_data &= ~CR_1000T_MS_ENABLE;
+		/* fall-through */
+	default:
+		break;
+	}
+
+	return e1e_wphy(hw, PHY_1000T_CTRL, phy_data);
+}
+
+/**
  *  e1000_copper_link_setup_82577 - Setup 82577 PHY for copper link
  *  @hw: pointer to the HW structure
  *
@@ -659,7 +698,11 @@ s32 e1000_copper_link_setup_82577(struct e1000_hw *hw)
 	/* Enable downshift */
 	phy_data |= I82577_CFG_ENABLE_DOWNSHIFT;
 
-	return e1e_wphy(hw, I82577_CFG_REG, phy_data);
+	ret_val = e1e_wphy(hw, I82577_CFG_REG, phy_data);
+	if (ret_val)
+		return ret_val;
+
+	return e1000_set_master_slave_mode(hw);
 }
 
 /**
@@ -895,31 +938,7 @@ s32 e1000e_copper_link_setup_igp(struct e1000_hw *hw)
 				return ret_val;
 		}
 
-		ret_val = e1e_rphy(hw, PHY_1000T_CTRL, &data);
-		if (ret_val)
-			return ret_val;
-
-		/* load defaults for future use */
-		phy->original_ms_type = (data & CR_1000T_MS_ENABLE) ?
-			((data & CR_1000T_MS_VALUE) ?
-			e1000_ms_force_master :
-			e1000_ms_force_slave) :
-			e1000_ms_auto;
-
-		switch (phy->ms_type) {
-		case e1000_ms_force_master:
-			data |= (CR_1000T_MS_ENABLE | CR_1000T_MS_VALUE);
-			break;
-		case e1000_ms_force_slave:
-			data |= CR_1000T_MS_ENABLE;
-			data &= ~(CR_1000T_MS_VALUE);
-			break;
-		case e1000_ms_auto:
-			data &= ~CR_1000T_MS_ENABLE;
-		default:
-			break;
-		}
-		ret_val = e1e_wphy(hw, PHY_1000T_CTRL, data);
+		ret_val = e1000_set_master_slave_mode(hw);
 	}
 
 	return ret_val;
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [net-next 2/4] e1000e: clear REQ and GNT in EECD (82571 && 82572)
  2012-05-05 12:38 [net-next 0/4][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
  2012-05-05 12:38 ` [net-next 1/4] e1000e: enable forced master/slave on 82577 Jeff Kirsher
@ 2012-05-05 12:38 ` Jeff Kirsher
  2012-05-05 12:38 ` [net-next 3/4] e1000e: increase version number Jeff Kirsher
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-05 12:38 UTC (permalink / raw)
  To: davem; +Cc: Richard Alpe, netdev, gospo, sassmann, Jeff Kirsher

From: Richard Alpe <richard.alpe@ericsson.com>

Clear the REQ and GNT bit in the eeprom control register (EECD).
This is required if the eeprom is to be accessed with auto read
EERD register.

After a cold reset this doesn't matter but if PBIST MAC test was
executed before booting, the register was left in a dirty state
(the 2 bits where set), which caused the read operation to time out
and returning 0.

Reference (page 312):
http://download.intel.com/design/network/manuals/316080.pdf

Reported-by: Aleksandar Igic <aleksandar.igic@dektech.com.au>
Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/e1000e/82571.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000e/82571.c b/drivers/net/ethernet/intel/e1000e/82571.c
index 6a8a908..36db4df 100644
--- a/drivers/net/ethernet/intel/e1000e/82571.c
+++ b/drivers/net/ethernet/intel/e1000e/82571.c
@@ -999,7 +999,7 @@ static s32 e1000_set_d0_lplu_state_82571(struct e1000_hw *hw, bool active)
  **/
 static s32 e1000_reset_hw_82571(struct e1000_hw *hw)
 {
-	u32 ctrl, ctrl_ext;
+	u32 ctrl, ctrl_ext, eecd;
 	s32 ret_val;
 
 	/*
@@ -1072,6 +1072,16 @@ static s32 e1000_reset_hw_82571(struct e1000_hw *hw)
 	 */
 
 	switch (hw->mac.type) {
+	case e1000_82571:
+	case e1000_82572:
+		/*
+		 * REQ and GNT bits need to be cleared when using AUTO_RD
+		 * to access the EEPROM.
+		 */
+		eecd = er32(EECD);
+		eecd &= ~(E1000_EECD_REQ | E1000_EECD_GNT);
+		ew32(EECD, eecd);
+		break;
 	case e1000_82573:
 	case e1000_82574:
 	case e1000_82583:
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [net-next 3/4] e1000e: increase version number
  2012-05-05 12:38 [net-next 0/4][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
  2012-05-05 12:38 ` [net-next 1/4] e1000e: enable forced master/slave on 82577 Jeff Kirsher
  2012-05-05 12:38 ` [net-next 2/4] e1000e: clear REQ and GNT in EECD (82571 && 82572) Jeff Kirsher
@ 2012-05-05 12:38 ` Jeff Kirsher
  2012-05-05 12:38 ` [net-next 4/4] ixgbe: dcb: IEEE PFC stats and reset logic incorrect Jeff Kirsher
  2012-05-06 17:25 ` [net-next 0/4][pull request] Intel Wired LAN Driver Updates David Miller
  4 siblings, 0 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-05 12:38 UTC (permalink / raw)
  To: davem; +Cc: Bruce Allan, netdev, gospo, sassmann, Jeff Kirsher

From: Bruce Allan <bruce.w.allan@intel.com>

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/e1000e/netdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index b53ea83..f648299 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -56,7 +56,7 @@
 
 #define DRV_EXTRAVERSION "-k"
 
-#define DRV_VERSION "1.11.3" DRV_EXTRAVERSION
+#define DRV_VERSION "2.0.0" DRV_EXTRAVERSION
 char e1000e_driver_name[] = "e1000e";
 const char e1000e_driver_version[] = DRV_VERSION;
 
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [net-next 4/4] ixgbe: dcb: IEEE PFC stats and reset logic incorrect
  2012-05-05 12:38 [net-next 0/4][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
                   ` (2 preceding siblings ...)
  2012-05-05 12:38 ` [net-next 3/4] e1000e: increase version number Jeff Kirsher
@ 2012-05-05 12:38 ` Jeff Kirsher
  2012-05-06 17:25 ` [net-next 0/4][pull request] Intel Wired LAN Driver Updates David Miller
  4 siblings, 0 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-05 12:38 UTC (permalink / raw)
  To: davem; +Cc: John Fastabend, netdev, gospo, sassmann, Jeff Kirsher

From: John Fastabend <john.r.fastabend@intel.com>

PFC stats are only tabulated when PFC is enabled. However in IEEE
mode the ieee_pfc pfc_tc bits were not checked and the calculation
was aborted.

This results in statistics not being reported through ethtool and
possible a false Tx hang occurring when receiving pause frames.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c |    7 +++++++
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c   |    6 +++++-
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c
index 652e4b0..2feacf6 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c
@@ -662,6 +662,13 @@ static int ixgbe_dcbnl_ieee_setpfc(struct net_device *dev,
 			return -ENOMEM;
 	}
 
+	if (pfc->pfc_en) {
+		adapter->last_lfc_mode = adapter->hw.fc.current_mode;
+		adapter->hw.fc.current_mode = ixgbe_fc_pfc;
+	} else {
+		adapter->hw.fc.current_mode = adapter->last_lfc_mode;
+	}
+
 	prio_tc = adapter->ixgbe_ieee_ets->prio_tc;
 	memcpy(adapter->ixgbe_ieee_pfc, pfc, sizeof(*adapter->ixgbe_ieee_pfc));
 	return ixgbe_dcb_hw_pfc_config(&adapter->hw, pfc->pfc_en, prio_tc);
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index b2daff3..4048c9d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -637,7 +637,11 @@ static void ixgbe_update_xoff_received(struct ixgbe_adapter *adapter)
 			clear_bit(__IXGBE_HANG_CHECK_ARMED,
 				  &adapter->tx_ring[i]->state);
 		return;
-	} else if (!(adapter->dcb_cfg.pfc_mode_enable))
+	} else if (((adapter->dcbx_cap & DCB_CAP_DCBX_VER_CEE) &&
+		    !(adapter->dcb_cfg.pfc_mode_enable)) ||
+		   ((adapter->dcbx_cap & DCB_CAP_DCBX_VER_IEEE) &&
+		    adapter->ixgbe_ieee_pfc &&
+		    !(adapter->ixgbe_ieee_pfc->pfc_en)))
 		return;
 
 	/* update stats for each tc, only valid with PFC enabled */
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-05-05 12:38 [net-next 0/4][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
                   ` (3 preceding siblings ...)
  2012-05-05 12:38 ` [net-next 4/4] ixgbe: dcb: IEEE PFC stats and reset logic incorrect Jeff Kirsher
@ 2012-05-06 17:25 ` David Miller
  2012-05-07  7:12   ` Jeff Kirsher
  4 siblings, 1 reply; 23+ messages in thread
From: David Miller @ 2012-05-06 17:25 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sat,  5 May 2012 05:38:09 -0700

> This series of patches contains updates for e1000e and ixgbe.
> 
> NOTE- The ixgbe patch can and probably should be applied to
> David Miller's net tree as well.
> 
> The following are changes since commit bd14b1b2e29bd6812597f896dde06eaf7c6d2f24:
>   tcp: be more strict before accepting ECN negociation
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

No new changes there?

[davem@drr net-next]$ git pull git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
>From git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next
 * branch            master     -> FETCH_HEAD
Already up-to-date.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-05-06 17:25 ` [net-next 0/4][pull request] Intel Wired LAN Driver Updates David Miller
@ 2012-05-07  7:12   ` Jeff Kirsher
  2012-05-07 16:33     ` David Miller
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-07  7:12 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, gospo, sassmann

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On Sun, 2012-05-06 at 13:25 -0400, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat,  5 May 2012 05:38:09 -0700
> 
> > This series of patches contains updates for e1000e and ixgbe.
> > 
> > NOTE- The ixgbe patch can and probably should be applied to
> > David Miller's net tree as well.
> > 
> > The following are changes since commit bd14b1b2e29bd6812597f896dde06eaf7c6d2f24:
> >   tcp: be more strict before accepting ECN negociation
> > and are available in the git repository at:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> 
> No new changes there?
> 
> [davem@drr net-next]$ git pull git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> From git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next
>  * branch            master     -> FETCH_HEAD
> Already up-to-date.

Sorry Dave, I thought I had pushed the changes but it appears I did not.
I have rectified that and now my net-next tree contains the four
patches.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-05-07  7:12   ` Jeff Kirsher
@ 2012-05-07 16:33     ` David Miller
  0 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2012-05-07 16:33 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 07 May 2012 00:12:58 -0700

> On Sun, 2012-05-06 at 13:25 -0400, David Miller wrote:
>> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> Date: Sat,  5 May 2012 05:38:09 -0700
>> 
>> > This series of patches contains updates for e1000e and ixgbe.
>> > 
>> > NOTE- The ixgbe patch can and probably should be applied to
>> > David Miller's net tree as well.
>> > 
>> > The following are changes since commit bd14b1b2e29bd6812597f896dde06eaf7c6d2f24:
>> >   tcp: be more strict before accepting ECN negociation
>> > and are available in the git repository at:
>> >   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
>> 
>> No new changes there?
>> 
>> [davem@drr net-next]$ git pull git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
>> From git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next
>>  * branch            master     -> FETCH_HEAD
>> Already up-to-date.
> 
> Sorry Dave, I thought I had pushed the changes but it appears I did not.
> I have rectified that and now my net-next tree contains the four
> patches.

That looks better, pulled, thanks Jeff.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2012-05-17 11:27 Jeff Kirsher
  2012-05-17 11:51 ` Jeff Kirsher
  2012-05-17 19:12 ` David Miller
  0 siblings, 2 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-17 11:27 UTC (permalink / raw)
  To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann

This series of patches contains updates for e1000, e1000e and igb.

The following are changes since commit dc6b9b78234fecdc6d2ca5e1629185718202bcf5:
  net: include/net/sock.h cleanup
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Bruce Allan (1):
  e1000e: fix typo in definition of E1000_CTRL_EXT_FORCE_SMBUS

Matthew Vick (1):
  igb: Disable the BMC-to-OS Watchdog Enable bit for DMAC.

Sebastian Andrzej Siewior (2):
  e1000: remove workaround for Errata 23 from jumbo alloc
  e1000: look in the page and not in skb->data for the last byte

 drivers/net/ethernet/intel/e1000/e1000_main.c  |   30 ++++--------------------
 drivers/net/ethernet/intel/e1000e/defines.h    |    2 +-
 drivers/net/ethernet/intel/igb/e1000_defines.h |    2 +
 drivers/net/ethernet/intel/igb/igb_main.c      |    3 ++
 4 files changed, 11 insertions(+), 26 deletions(-)

-- 
1.7.7.6

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-05-17 11:27 Jeff Kirsher
@ 2012-05-17 11:51 ` Jeff Kirsher
  2012-05-17 19:12 ` David Miller
  1 sibling, 0 replies; 23+ messages in thread
From: Jeff Kirsher @ 2012-05-17 11:51 UTC (permalink / raw)
  To: davem; +Cc: netdev, gospo, sassmann

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On Thu, 2012-05-17 at 04:27 -0700, Jeff Kirsher wrote:
> This series of patches contains updates for e1000, e1000e and igb.
> 
> The following are changes since commit dc6b9b78234fecdc6d2ca5e1629185718202bcf5:
>   net: include/net/sock.h cleanup
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> 
> Bruce Allan (1):
>   e1000e: fix typo in definition of E1000_CTRL_EXT_FORCE_SMBUS
> 
> Matthew Vick (1):
>   igb: Disable the BMC-to-OS Watchdog Enable bit for DMAC.
> 
> Sebastian Andrzej Siewior (2):
>   e1000: remove workaround for Errata 23 from jumbo alloc
>   e1000: look in the page and not in skb->data for the last byte
> 
>  drivers/net/ethernet/intel/e1000/e1000_main.c  |   30 ++++--------------------
>  drivers/net/ethernet/intel/e1000e/defines.h    |    2 +-
>  drivers/net/ethernet/intel/igb/e1000_defines.h |    2 +
>  drivers/net/ethernet/intel/igb/igb_main.c      |    3 ++
>  4 files changed, 11 insertions(+), 26 deletions(-)
> 

v2 of the series will be coming.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-05-17 11:27 Jeff Kirsher
  2012-05-17 11:51 ` Jeff Kirsher
@ 2012-05-17 19:12 ` David Miller
  1 sibling, 0 replies; 23+ messages in thread
From: David Miller @ 2012-05-17 19:12 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 17 May 2012 04:27:46 -0700

> This series of patches contains updates for e1000, e1000e and igb.
> 
> The following are changes since commit dc6b9b78234fecdc6d2ca5e1629185718202bcf5:
>   net: include/net/sock.h cleanup
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Pulled, thanks.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2012-09-05  6:25 Jeff Kirsher
  2012-09-05 19:10 ` David Miller
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2012-09-05  6:25 UTC (permalink / raw)
  To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann

This series contains updates to igb and ixgbe.

The following are changes since commit 600e177920df936d03b807780ca92c662af98990:
  net: Providing protocol type via system.sockprotoname xattr of /proc/PID/fd entries
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Akeem G. Abodunrin (1):
  igb: Supported and Advertised Pause Frame

Carolyn Wyborny (1):
  igb: Add loopback test support for i210

Eliezer Tamir (1):
  ixgbe: remove old init remnant

Eric Dumazet (1):
  igb: reduce Rx header size

 drivers/net/ethernet/intel/igb/igb.h          |  4 +-
 drivers/net/ethernet/intel/igb/igb_ethtool.c  | 72 +++++++++++++--------------
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  5 --
 3 files changed, 36 insertions(+), 45 deletions(-)

-- 
1.7.11.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-09-05  6:25 Jeff Kirsher
@ 2012-09-05 19:10 ` David Miller
  0 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2012-09-05 19:10 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue,  4 Sep 2012 23:25:46 -0700

> This series contains updates to igb and ixgbe.
> 
> The following are changes since commit 600e177920df936d03b807780ca92c662af98990:
>   net: Providing protocol type via system.sockprotoname xattr of /proc/PID/fd entries
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Pulled, thanks Jeff.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [net-next 0/4][pull request] Intel Wired LAN Driver Updates
@ 2012-09-19  4:31 Jeff Kirsher
  2012-09-19  6:03 ` Jeff Kirsher
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2012-09-19  4:31 UTC (permalink / raw)
  To: davem; +Cc: Jeff Kirsher, netdev, gospo, sassmann

This series contains updates to igb and ixgbevf.

The following are changes since commit adccff34de1ef81564b7e6c436f762e7a1caf807:
  net/tipc/name_table.c: Remove unecessary semicolon
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master

Akeem G. Abodunrin (1):
  igb: Support to enable EEE on all eee_supported devices

Alexander Duyck (2):
  igb: Remove artificial restriction on RQDPC stat reading
  ixgbevf: Add support for VF API negotiation

John Fastabend (1):
  ixgbevf: scheduling while atomic in reset hw path

 drivers/net/ethernet/intel/igb/e1000_82575.c      | 17 +++++++---
 drivers/net/ethernet/intel/igb/e1000_defines.h    |  3 +-
 drivers/net/ethernet/intel/igb/e1000_regs.h       |  1 +
 drivers/net/ethernet/intel/igb/igb_main.c         |  8 +++--
 drivers/net/ethernet/intel/ixgbevf/defines.h      |  1 +
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 +++++++++++++
 drivers/net/ethernet/intel/ixgbevf/mbx.h          | 21 ++++++++++--
 drivers/net/ethernet/intel/ixgbevf/vf.c           | 39 ++++++++++++++++++++++-
 drivers/net/ethernet/intel/ixgbevf/vf.h           |  3 ++
 9 files changed, 105 insertions(+), 11 deletions(-)

-- 
1.7.11.4

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-09-19  4:31 Jeff Kirsher
@ 2012-09-19  6:03 ` Jeff Kirsher
  2012-09-19  6:19   ` David Miller
  0 siblings, 1 reply; 23+ messages in thread
From: Jeff Kirsher @ 2012-09-19  6:03 UTC (permalink / raw)
  To: davem; +Cc: netdev, gospo, sassmann

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

On Tue, 2012-09-18 at 21:31 -0700, Jeff Kirsher wrote:
> This series contains updates to igb and ixgbevf.
> 
> The following are changes since commit adccff34de1ef81564b7e6c436f762e7a1caf807:
>   net/tipc/name_table.c: Remove unecessary semicolon
> and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
> 
> Akeem G. Abodunrin (1):
>   igb: Support to enable EEE on all eee_supported devices
> 
> Alexander Duyck (2):
>   igb: Remove artificial restriction on RQDPC stat reading
>   ixgbevf: Add support for VF API negotiation
> 
> John Fastabend (1):
>   ixgbevf: scheduling while atomic in reset hw path
> 
>  drivers/net/ethernet/intel/igb/e1000_82575.c      | 17 +++++++---
>  drivers/net/ethernet/intel/igb/e1000_defines.h    |  3 +-
>  drivers/net/ethernet/intel/igb/e1000_regs.h       |  1 +
>  drivers/net/ethernet/intel/igb/igb_main.c         |  8 +++--
>  drivers/net/ethernet/intel/ixgbevf/defines.h      |  1 +
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 +++++++++++++
>  drivers/net/ethernet/intel/ixgbevf/mbx.h          | 21 ++++++++++--
>  drivers/net/ethernet/intel/ixgbevf/vf.c           | 39 ++++++++++++++++++++++-
>  drivers/net/ethernet/intel/ixgbevf/vf.h           |  3 ++
>  9 files changed, 105 insertions(+), 11 deletions(-)
> 

Dave,

Do not pull, it appears there will be changes to patch 04 of the series,
I will be sending a v2 of the series once John gets patch 04 fixed up.

Cheers,
Jeff

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [net-next 0/4][pull request] Intel Wired LAN Driver Updates
  2012-09-19  6:03 ` Jeff Kirsher
@ 2012-09-19  6:19   ` David Miller
  0 siblings, 0 replies; 23+ messages in thread
From: David Miller @ 2012-09-19  6:19 UTC (permalink / raw)
  To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 18 Sep 2012 23:03:55 -0700

> Do not pull, it appears there will be changes to patch 04 of the series,
> I will be sending a v2 of the series once John gets patch 04 fixed up.

Ok.

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2012-09-19  6:19 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-05 12:38 [net-next 0/4][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-05-05 12:38 ` [net-next 1/4] e1000e: enable forced master/slave on 82577 Jeff Kirsher
2012-05-05 12:38 ` [net-next 2/4] e1000e: clear REQ and GNT in EECD (82571 && 82572) Jeff Kirsher
2012-05-05 12:38 ` [net-next 3/4] e1000e: increase version number Jeff Kirsher
2012-05-05 12:38 ` [net-next 4/4] ixgbe: dcb: IEEE PFC stats and reset logic incorrect Jeff Kirsher
2012-05-06 17:25 ` [net-next 0/4][pull request] Intel Wired LAN Driver Updates David Miller
2012-05-07  7:12   ` Jeff Kirsher
2012-05-07 16:33     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2012-09-19  4:31 Jeff Kirsher
2012-09-19  6:03 ` Jeff Kirsher
2012-09-19  6:19   ` David Miller
2012-09-05  6:25 Jeff Kirsher
2012-09-05 19:10 ` David Miller
2012-05-17 11:27 Jeff Kirsher
2012-05-17 11:51 ` Jeff Kirsher
2012-05-17 19:12 ` David Miller
2012-03-03  2:26 Jeff Kirsher
2012-03-03 19:53 ` David Miller
2012-03-03  2:24 Jeff Kirsher
2012-03-03  2:27 ` Jeff Kirsher
2011-01-22 11:56 Jeff Kirsher
2011-01-24  8:19 ` Jeff Kirsher
2011-01-24 21:02   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).