From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>,
David Herrmann <dh.herrmann@googlemail.com>,
linux-bluetooth@vger.kernel.org, netdev <netdev@vger.kernel.org>,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: batostr() function
Date: Tue, 08 May 2012 19:48:33 +0200 [thread overview]
Message-ID: <1336499313.4320.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1336497532.29640.24.camel@joe2Laptop>
On Tue, 2012-05-08 at 10:18 -0700, Joe Perches wrote:
> On Tue, 2012-05-08 at 17:30 +0300, Andrei Emeltchenko wrote:
> > On Tue, May 08, 2012 at 04:25:08PM +0200, Johannes Berg wrote:
> > > On Tue, 2012-05-08 at 15:30 +0200, David Herrmann wrote:
> > > > Hi Johannes
> > > >
> > > > On Mon, May 7, 2012 at 1:49 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > > > > Really? 2 static buffers that are used alternately based on a static
> > > > > variable? How can that possibly be thread-safe? That may work in very
> > > > > restricted scenarios, but ...
> > > >
> > > > Looking at "git blame" it seems the whole function is still from
> > > > linux-2.4. Looks like no-one ever noticed. I've sent a patchset fixing
> > > > it, thanks.
> > >
> > > I was thinking you could use %pM, but it seems BT addresses are stored
> > > the wrong way around for some reason ...
> >
> > This looks like better idea then allocating buffers, we can use swap to
> > take care about "wrong order".
>
> https://lkml.org/lkml/2010/12/3/358
Pretty much what I had in mind, thanks. Luis, you'll notice that this
will be a pain to backport in compat. :-)
johannes
next prev parent reply other threads:[~2012-05-08 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 11:49 batostr() function Johannes Berg
[not found] ` <1336391383.4325.24.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-08 13:30 ` David Herrmann
[not found] ` <CANq1E4QW4vSn_r9C=rirShE+-eyPjRX+b5tpC+mx69Hs6aEYqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-08 14:20 ` Ulisses Furquim
2012-05-08 14:25 ` Johannes Berg
2012-05-08 14:30 ` Andrei Emeltchenko
2012-05-08 17:18 ` Joe Perches
2012-05-08 17:48 ` Johannes Berg [this message]
[not found] ` <1336499313.4320.4.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-08 18:26 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336499313.4320.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=joe@perches.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).