From mboxrd@z Thu Jan 1 00:00:00 1970 From: pablo@netfilter.org Subject: [PATCH 20/25] ipvs: ip_vs_ftp: local functions should not be exposed globally Date: Tue, 8 May 2012 20:38:18 +0200 Message-ID: <1336502303-1722-21-git-send-email-pablo@netfilter.org> References: <1336502303-1722-1-git-send-email-pablo@netfilter.org> Cc: davem@davemloft.net, openbsc@lists.osmocom.org To: netdev@vger.kernel.org Return-path: Received: from mail.us.es ([193.147.175.20]:39623 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756670Ab2EHSkZ (ORCPT ); Tue, 8 May 2012 14:40:25 -0400 In-Reply-To: <1336502303-1722-1-git-send-email-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-ID: From: H Hartley Sweeten Functions not referenced outside of a source file should be marked static to prevent it from being exposed globally. This quiets the sparse warnings: warning: symbol 'ip_vs_ftp_init' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_ftp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c index 510f2b5..b20b29c 100644 --- a/net/netfilter/ipvs/ip_vs_ftp.c +++ b/net/netfilter/ipvs/ip_vs_ftp.c @@ -485,7 +485,7 @@ static struct pernet_operations ip_vs_ftp_ops = { .exit = __ip_vs_ftp_exit, }; -int __init ip_vs_ftp_init(void) +static int __init ip_vs_ftp_init(void) { int rv; -- 1.7.9.5