public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <ordex@autistici.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Linus Luessing <linus.luessing@web.de>,
	Marek Lindner <lindner_marek@yahoo.de>,
	Antonio Quartulli <ordex@autistici.org>
Subject: [PATCH 11/15] batman-adv: Adding hard_iface specific sysfs wrapper macros for UINT
Date: Fri, 11 May 2012 14:21:28 +0200	[thread overview]
Message-ID: <1336738892-7401-12-git-send-email-ordex@autistici.org> (raw)
In-Reply-To: <1336738892-7401-1-git-send-email-ordex@autistici.org>

From: Linus Luessing <linus.luessing@web.de>

This allows us to easily add a sysfs parameter for an unsigned int
later, which is not for a batman mesh interface (e.g. bat0), but for a
common interface instead. It allows reading and writing an atomic_t in
hard_iface (instead of bat_priv compared to the mesh variant).

Developed by Linus during a 6 months trainee study period in Ascom
(Switzerland) AG.

Signed-off-by: Linus Luessing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
 net/batman-adv/bat_sysfs.c |   43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/net/batman-adv/bat_sysfs.c b/net/batman-adv/bat_sysfs.c
index 913299d..5bc7b66 100644
--- a/net/batman-adv/bat_sysfs.c
+++ b/net/batman-adv/bat_sysfs.c
@@ -117,6 +117,49 @@ ssize_t show_##_name(struct kobject *kobj,				\
 	static BAT_ATTR(_name, _mode, show_##_name, store_##_name)
 
 
+#define BAT_ATTR_HIF_STORE_UINT(_name, _min, _max, _post_func)		\
+ssize_t store_##_name(struct kobject *kobj, struct attribute *attr,	\
+		      char *buff, size_t count)				\
+{									\
+	struct net_device *net_dev = kobj_to_netdev(kobj);		\
+	struct hard_iface *hard_iface = hardif_get_by_netdev(net_dev);	\
+	ssize_t length;							\
+									\
+	if (!hard_iface)						\
+		return 0;						\
+									\
+	length = __store_uint_attr(buff, count, _min, _max, _post_func,	\
+				   attr, &hard_iface->_name, net_dev);	\
+									\
+	hardif_free_ref(hard_iface);					\
+	return length;							\
+}
+
+#define BAT_ATTR_HIF_SHOW_UINT(_name)					\
+ssize_t show_##_name(struct kobject *kobj,				\
+		     struct attribute *attr, char *buff)		\
+{									\
+	struct net_device *net_dev = kobj_to_netdev(kobj);		\
+	struct hard_iface *hard_iface = hardif_get_by_netdev(net_dev);	\
+	ssize_t length;							\
+									\
+	if (!hard_iface)						\
+		return 0;						\
+									\
+	length = sprintf(buff, "%i\n", atomic_read(&hard_iface->_name));\
+									\
+	hardif_free_ref(hard_iface);					\
+	return length;							\
+}
+
+/* Use this, if you are going to set [name] in hard_iface to an
+ * unsigned integer value*/
+#define BAT_ATTR_HIF_UINT(_name, _mode, _min, _max, _post_func)		\
+	static BAT_ATTR_HIF_STORE_UINT(_name, _min, _max, _post_func)	\
+	static BAT_ATTR_HIF_SHOW_UINT(_name)				\
+	static BAT_ATTR(_name, _mode, show_##_name, store_##_name)
+
+
 static int store_bool_attr(char *buff, size_t count,
 			   struct net_device *net_dev,
 			   const char *attr_name, atomic_t *attr)
-- 
1.7.9.4

  parent reply	other threads:[~2012-05-11 12:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 12:21 pull request: batman-adv 2012-05-11 Antonio Quartulli
     [not found] ` <1336738892-7401-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org>
2012-05-11 12:21   ` [PATCH 01/15] batman-adv: fix wrong dhcp option list browsing Antonio Quartulli
2012-05-11 22:01   ` pull request: batman-adv 2012-05-11 David Miller
     [not found]     ` <20120511.180144.174337959525316777.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-11 22:10       ` Sven Eckelmann
2012-05-11 12:21 ` [PATCH 02/15] batman-adv: introduce is_single_hop_neigh variable to increase readability Antonio Quartulli
2012-05-11 12:21 ` [PATCH 03/15] batman-adv: introduce packet type handler array for incoming packets Antonio Quartulli
2012-05-11 12:21 ` [PATCH 04/15] batman-adv: register batman ogm receive function during protocol init Antonio Quartulli
2012-05-11 12:21 ` [PATCH 05/15] batman-adv: rename last_valid to last_seen Antonio Quartulli
2012-05-11 12:21 ` [PATCH 06/15] batman-adv: replace HZ calculations with jiffies_to_msecs() Antonio Quartulli
2012-05-11 12:21 ` [PATCH 07/15] batman-adv: split neigh_new function into generic and batman iv specific parts Antonio Quartulli
2012-05-11 12:21 ` [PATCH 08/15] batman-adv: ignore protocol packets if the interface did not enable this protocol Antonio Quartulli
2012-05-11 12:21 ` [PATCH 09/15] batman-adv: refactoring API: find generalized name for bat_ogm_update_mac callback Antonio Quartulli
2012-05-11 12:21 ` [PATCH 10/15] batman-adv: rename sysfs macros to reflect the soft-interface dependency Antonio Quartulli
2012-05-11 12:21 ` Antonio Quartulli [this message]
2012-05-11 12:21 ` [PATCH 12/15] batman-adv: avoid temporary routing loops by being strict on forwarded OGMs Antonio Quartulli
2012-05-11 12:21 ` [PATCH 13/15] batman-adv: fix checkpatch string complaint Antonio Quartulli
2012-05-11 12:21 ` [PATCH 14/15] batman-adv: update copyright years Antonio Quartulli
2012-05-11 12:21 ` [PATCH 15/15] batman-adv: add contributor name Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336738892-7401-12-git-send-email-ordex@autistici.org \
    --to=ordex@autistici.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=lindner_marek@yahoo.de \
    --cc=linus.luessing@web.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox