Re: [PATCH net-next v3] be2net: Fix to allow get/set of debug levels in the firmware.

[Ben Hutchings <bhutchings@solarflare.com>]

On Sat, 2012-05-12 at 09:09 +0530, Somnath Kotur wrote:
[...]
> +static void be_set_msg_level(struct net_device *netdev, u32 level)
> +{
> +	struct be_adapter *adapter = netdev_priv(netdev);
> +
> +	if (lancer_chip(adapter)) {
> +		dev_err(&adapter->pdev->dev, "Operation not supported\n");
> +		return;
> +	}
> +
> +	if (adapter->msg_enable == level)
> +		return;
> +
> +	if (level & NETIF_MSG_HW != adapter->msg_enable & NETIF_MSG_HW)
> +		be_set_fw_log_level(adapter, level & NETIF_MSG_HW ?
> +			       	    FW_LOG_LEVEL_DEFAULT : FW_LOG_LEVEL_FATAL);
[...]

Oh, come on, you can't have actually tested this.  The compiler even
warns you this is probably wrong.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.