From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: David Laight <David.Laight@ACULAB.COM>,
netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [PATCH 1/4] netfilter: ipset: fix timeout value overflow bug
Date: Mon, 14 May 2012 16:47:24 +0200 [thread overview]
Message-ID: <1337006844.8512.491.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120514143635.GA12992@1984>
On Mon, 2012-05-14 at 16:36 +0200, Pablo Neira Ayuso wrote:
> On Mon, May 14, 2012 at 03:19:49PM +0100, David Laight wrote:
> >
> > > --- a/include/linux/netfilter/ipset/ip_set_timeout.h
> > > +++ b/include/linux/netfilter/ipset/ip_set_timeout.h
> > > @@ -30,6 +30,10 @@ ip_set_timeout_uget(struct nlattr *tb)
> > > {
> > > unsigned int timeout = ip_set_get_h32(tb);
> > >
> > > + /* Normalize to fit into jiffies */
> > > + if (timeout > UINT_MAX/1000)
> > > + timeout = UINT_MAX/1000;
> > > +
> >
> > Doesn't that rather assume that HZ is 1000 ?
>
> Indeed. I overlooked that. Thanks David.
I dont think so.
1000 here is really MSEC_PER_SEC
(All occurrences should be changed in this file)
next prev parent reply other threads:[~2012-05-14 14:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 11:46 [PATCH 0/4] netfilter fixes for 3.4-rc7 pablo
2012-05-14 11:47 ` [PATCH 1/4] netfilter: ipset: fix timeout value overflow bug pablo
2012-05-14 14:19 ` David Laight
2012-05-14 14:36 ` Pablo Neira Ayuso
2012-05-14 14:47 ` Eric Dumazet [this message]
2012-05-14 17:45 ` Jozsef Kadlecsik
2012-05-14 19:00 ` Pablo Neira Ayuso
2012-05-14 20:10 ` Pablo Neira Ayuso
2012-05-14 21:45 ` Jozsef Kadlecsik
2012-05-15 8:21 ` David Laight
2012-05-14 11:47 ` [PATCH 2/4] netfilter: ipset: fix hash size checking in kernel pablo
2012-05-14 11:47 ` [PATCH 3/4] netfilter: xt_CT: remove redundant header include pablo
2012-05-14 11:47 ` [PATCH 4/4] netfilter: nf_ct_h323: fix usage of MODULE_ALIAS_NFCT_HELPER pablo
2012-05-14 22:56 ` [PATCH 0/4] netfilter fixes for 3.4-rc7 David Miller
2012-05-14 23:25 ` Pablo Neira Ayuso
2012-05-16 18:41 ` Jozsef Kadlecsik
2012-05-16 19:18 ` David Miller
2012-05-16 19:34 ` Jozsef Kadlecsik
2012-05-16 19:39 ` David Miller
2012-05-16 19:48 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337006844.8512.491.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox