From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hans Schillstrom <hans.schillstrom@ericsson.com>
Cc: Jan Engelhardt <jengelh@inai.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"kaber@trash.net" <kaber@trash.net>,
"jengelh@medozas.de" <jengelh@medozas.de>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"hans@schillstrom.com" <hans@schillstrom.com>
Subject: Re: [PATCH] netfilter: xt_HMARK: endian bugs
Date: Mon, 14 May 2012 18:24:34 +0200 [thread overview]
Message-ID: <1337012674.8512.589.camel@edumazet-glaptop> (raw)
In-Reply-To: <201205141809.18174.hans.schillstrom@ericsson.com>
On Mon, 2012-05-14 at 18:09 +0200, Hans Schillstrom wrote:
> This context can contain both le & be machines,
> so at least in hmark it make sense
Before jhash() and its shuffle ? What do you mean ?
Please respin your patch using (__force u16/u32) instead of
useless/expensive ntohs() / ntohl() (in _this_ context of hashing)
If you compare two 32bits values, of course they must have same
ordering, but seeding jhash() is another matter.
(Granted all calls use the same ordering of course)
sparse is great tool, but if you add useless ntohl() calls to make
sparse silent, then its probably better to not use sparse.
next prev parent reply other threads:[~2012-05-14 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 13:42 [PATCH] netfilter: xt_HMARK: endian bugs Hans Schillstrom
2012-05-14 14:40 ` Pablo Neira Ayuso
2012-05-14 15:05 ` Hans Schillstrom
2012-05-14 15:05 ` Jan Engelhardt
2012-05-14 15:24 ` Eric Dumazet
2012-05-14 16:09 ` Hans Schillstrom
2012-05-14 16:24 ` Eric Dumazet [this message]
2012-05-14 17:51 ` Hans Schillstrom
2012-05-14 18:24 ` Jan Engelhardt
2012-05-14 18:28 ` Eric Dumazet
2012-05-14 18:35 ` Jozsef Kadlecsik
2012-05-14 19:02 ` Pablo Neira Ayuso
2012-05-14 19:13 ` Eric Dumazet
2012-05-15 5:57 ` Hans Schillström
2012-05-15 7:33 ` Hans Schillström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337012674.8512.589.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=hans.schillstrom@ericsson.com \
--cc=hans@schillstrom.com \
--cc=jengelh@inai.de \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox