From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com>,
arnd@arndb.de, s.hauer@pengutronix.de, gfm@funxed.com,
davem@davemloft.net, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms
Date: Tue, 15 May 2012 16:08:34 -0700 [thread overview]
Message-ID: <1337123314.7050.26.camel@joe2Laptop> (raw)
In-Reply-To: <20120515223711.GA12674@electric-eye.fr.zoreil.com>
On Wed, 2012-05-16 at 00:37 +0200, Francois Romieu wrote:
> Jaccon Bastiaansen <jaccon.bastiaansen@gmail.com> :
> [...]
> > diff --git a/drivers/net/ethernet/cirrus/cs89x0.c b/drivers/net/ethernet/cirrus/cs89x0.c
> > index b9406cb..8081ad5 100644
> > --- a/drivers/net/ethernet/cirrus/cs89x0.c
> > +++ b/drivers/net/ethernet/cirrus/cs89x0.c
> [...]
> > -static int cs89x0_probe1(struct net_device *dev, unsigned long ioaddr, int modular);
> > +static int cs89x0_probe1(struct net_device *dev,
> > + void __iomem *ioaddr,
> > + int modular);
> > +static int cs89x0_probe1(struct net_device *dev, void __iomem *ioaddr,
> > + int modular);
>
> s/int/bool/ maybe.
>
> You may skip the name of the parameters.
Better would be to not duplicate the prototype
and better still would be to reorder the code to
avoid the prototype altogether.
next prev parent reply other threads:[~2012-05-15 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 20:15 [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms Jaccon Bastiaansen
2012-05-15 21:22 ` Arnd Bergmann
2012-05-15 22:37 ` Francois Romieu
2012-05-15 23:08 ` Joe Perches [this message]
2012-05-16 7:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337123314.7050.26.camel@joe2Laptop \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=gfm@funxed.com \
--cc=jaccon.bastiaansen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).