From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr_debug
Date: Tue, 15 May 2012 18:49:47 -0700 [thread overview]
Message-ID: <1337132987.7050.29.camel@joe2Laptop> (raw)
In-Reply-To: <20120515183536.2cac1e29@nehalam.linuxnetplumber.net>
On Tue, 2012-05-15 at 18:35 -0700, Stephen Hemminger wrote:
> On Tue, 15 May 2012 17:11:54 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > Use the current debugging style and enable dynamic_debug.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> This changes the action of the system. By default:
> printk(KERN_DEBUG "foo\n");
> is enabled all the time and prints to log with debug level.
>
> But your version
> pr_debug("foo\n");
> defaults to being dropped until the system is built with dynamic
> debug, and that particular debug instance is enabled.
>
> Since these are all useful, but low priority messages, not I
> don't think disabling them by default is such a great idea now.
Just had that discussion with David Miller.
http://marc.info/?l=linux-sctp&m=133710673230503&w=2
next prev parent reply other threads:[~2012-05-16 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 0:11 [PATCH net-next 0/2] net/ipv4 and net/ipv6 logging cleanups Joe Perches
2012-05-16 0:11 ` [PATCH net-next 1/2] net: ipv6: Standardize prefixes for message logging Joe Perches
2012-05-16 0:11 ` [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-05-16 1:35 ` Stephen Hemminger
2012-05-16 1:49 ` Joe Perches [this message]
2012-05-16 5:01 ` [PATCH net-next 0/2] net/ipv4 and net/ipv6 logging cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337132987.7050.29.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).