From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] net: mac80211: Neaten debugging
Date: Wed, 16 May 2012 17:30:20 +0200 [thread overview]
Message-ID: <1337182220.18519.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1337181771.4818.0.camel@joe2Laptop>
On Wed, 2012-05-16 at 08:22 -0700, Joe Perches wrote:
> On Wed, 2012-05-16 at 09:59 +0200, Johannes Berg wrote:
> > I wonder if it makes sense to leave these under
> > #ifdef though? Why #ifdef something if it's going to be invisible most
> > of the time anyway?
>
> I don't understand your point.
> #ifdef removal is a good thing.
Yeah, but you left a lot of them under ifdef, and I'm wondering why you
didn't remove them, or if you should, or ...
johannes
next prev parent reply other threads:[~2012-05-16 15:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 7:56 [RFC net-next 0/2] net: Use net_<level>_ratelimit Joe Perches
2012-05-14 7:56 ` [RFC net-next 1/2] net: Add net_ratelimited_function and net_<level>_ratelimited macros Joe Perches
2012-05-14 7:56 ` [RFC net-next 2/2] net: Convert net_ratelimit uses to net_<level>_ratelimited Joe Perches
[not found] ` <cover.1336981915.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2012-05-15 17:45 ` [RFC net-next 0/2] net: Use net_<level>_ratelimit David Miller
[not found] ` <20120515.134531.530903973750646107.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-15 17:59 ` Joe Perches
2012-05-15 18:03 ` Johannes Berg
[not found] ` <1337105028.15553.3.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-15 18:13 ` David Miller
[not found] ` <20120515.141348.892964316296815698.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-15 18:21 ` Johannes Berg
[not found] ` <1337106094.15553.5.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-15 18:24 ` David Miller
[not found] ` <20120515.142405.633851408201128056.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-15 18:29 ` Johannes Berg
[not found] ` <1337106548.15553.8.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-15 18:30 ` David Miller
2012-05-15 21:20 ` [PATCH 0/3] net: mac80211: Neaten debugging Joe Perches
2012-05-15 21:20 ` [PATCH 1/3] net: mac80211: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-05-15 21:20 ` [PATCH 2/3] net: mac80211: Add and use ht_vdbg debugging macro Joe Perches
2012-05-15 21:20 ` [PATCH 3/3] net: mac80211: Add and use ibss_vdbg " Joe Perches
2012-05-16 5:23 ` [PATCH 0/3] net: mac80211: Neaten debugging David Miller
2012-05-16 7:59 ` Johannes Berg
2012-05-16 15:22 ` Joe Perches
2012-05-16 15:30 ` Johannes Berg [this message]
2012-05-16 15:43 ` Joe Perches
2012-05-16 15:56 ` Johannes Berg
2012-05-15 18:14 ` [RFC net-next 0/2] net: Use net_<level>_ratelimit David Miller
2012-05-15 18:27 ` Johannes Berg
[not found] ` <1337106430.15553.6.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-15 18:29 ` David Miller
[not found] ` <20120515.142922.1434224550630736456.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-05-15 18:40 ` Johannes Berg
[not found] ` <1337107245.15553.14.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2012-05-15 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337182220.18519.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).