public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Willy Tarreau <w@1wt.eu>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next] net: netdev_alloc_skb() use build_skb()
Date: Thu, 17 May 2012 19:34:16 +0200	[thread overview]
Message-ID: <1337276056.3403.37.camel@edumazet-glaptop> (raw)
In-Reply-To: <1337273387.3403.24.camel@edumazet-glaptop>

From: Eric Dumazet <edumazet@google.com>

Please note I havent tested yet this patch, lacking hardware for this.

(tg3/bnx2/bnx2x use build_skb, r8169 does a copy of incoming frames,
ixgbe uses fragments...)

Any volunteer ?

Thanks

[PATCH net-next] net: netdev_alloc_skb() use build_skb()

netdev_alloc_skb() is used by networks driver in their RX path to
allocate an skb to receive an incoming frame.

With recent skb->head_frag infrastructure, it makes sense to change
netdev_alloc_skb() to use build_skb() and a frag allocator.

This permits a zero copy splice(socket->pipe), and better GRO or TCP
coalescing.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/core/skbuff.c |   32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 2a18719..c02a8ec 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -293,6 +293,12 @@ struct sk_buff *build_skb(void *data, unsigned int frag_size)
 }
 EXPORT_SYMBOL(build_skb);
 
+struct netdev_alloc_cache {
+	struct page *page;
+	unsigned int offset;
+};
+static DEFINE_PER_CPU(struct netdev_alloc_cache, netdev_alloc_cache);
+
 /**
  *	__netdev_alloc_skb - allocate an skbuff for rx on a specific device
  *	@dev: network device to receive on
@@ -310,8 +316,32 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev,
 		unsigned int length, gfp_t gfp_mask)
 {
 	struct sk_buff *skb;
+	unsigned int fragsz = SKB_DATA_ALIGN(length + NET_SKB_PAD) +
+			      SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
 
-	skb = __alloc_skb(length + NET_SKB_PAD, gfp_mask, 0, NUMA_NO_NODE);
+	if (fragsz <= PAGE_SIZE && !(gfp_mask & __GFP_WAIT)) {
+		struct netdev_alloc_cache *nc;
+		void *data = NULL;
+
+		nc = &get_cpu_var(netdev_alloc_cache);
+		if (!nc->page) {
+refill:			nc->page = alloc_page(gfp_mask);
+			nc->offset = 0;
+		}
+		if (likely(nc->page)) {
+			if (nc->offset + fragsz > PAGE_SIZE) {
+				put_page(nc->page);
+				goto refill;
+			}
+			data = page_address(nc->page) + nc->offset;
+			nc->offset += fragsz;
+			get_page(nc->page);
+		}
+		put_cpu_var(netdev_alloc_cache);
+		skb = data ? build_skb(data, fragsz) : NULL;
+	} else {
+		skb = __alloc_skb(length + NET_SKB_PAD, gfp_mask, 0, NUMA_NO_NODE);
+	}
 	if (likely(skb)) {
 		skb_reserve(skb, NET_SKB_PAD);
 		skb->dev = dev;

  parent reply	other threads:[~2012-05-17 17:34 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 12:18 Stable regression with 'tcp: allow splice() to build full TSO packets' Willy Tarreau
2012-05-17 15:01 ` Willy Tarreau
2012-05-17 15:43   ` Eric Dumazet
2012-05-17 15:56     ` Willy Tarreau
2012-05-17 16:33       ` Eric Dumazet
2012-05-17 16:40         ` Willy Tarreau
2012-05-17 16:47           ` Eric Dumazet
2012-05-17 16:49           ` Eric Dumazet
2012-05-17 17:22             ` Willy Tarreau
2012-05-17 17:34             ` Eric Dumazet [this message]
2012-05-17 17:45               ` [PATCH net-next] net: netdev_alloc_skb() use build_skb() Willy Tarreau
2012-06-04 12:39                 ` Michael S. Tsirkin
2012-06-04 12:44                   ` Willy Tarreau
2012-05-17 19:53               ` David Miller
2012-05-18  4:41                 ` Eric Dumazet
2012-06-04 12:37               ` Michael S. Tsirkin
2012-06-04 13:06                 ` Eric Dumazet
2012-06-04 13:41                   ` Michael S. Tsirkin
2012-06-04 14:01                     ` Eric Dumazet
2012-06-04 14:09                       ` Eric Dumazet
2012-06-04 14:17                       ` Michael S. Tsirkin
2012-06-04 15:01                         ` Eric Dumazet
2012-06-04 17:20                           ` Michael S. Tsirkin
2012-06-04 17:44                             ` Eric Dumazet
2012-06-04 18:16                               ` Michael S. Tsirkin
2012-06-04 19:24                                 ` Eric Dumazet
2012-06-04 19:48                                   ` Michael S. Tsirkin
2012-06-04 19:56                                     ` Eric Dumazet
2012-06-04 21:20                                       ` Michael S. Tsirkin
2012-06-05  2:50                                         ` Eric Dumazet
2012-06-04 18:16                           ` Michael S. Tsirkin
2012-06-04 19:29                             ` Eric Dumazet
2012-06-04 19:43                               ` Michael S. Tsirkin
2012-06-04 19:52                                 ` Eric Dumazet
2012-06-04 21:54                                   ` Michael S. Tsirkin
2012-06-05  2:46                                     ` Eric Dumazet
2012-06-04 19:56                                 ` Michael S. Tsirkin
2012-06-04 20:05                                   ` Eric Dumazet
2012-05-17 18:38       ` Stable regression with 'tcp: allow splice() to build full TSO packets' Ben Hutchings
2012-05-17 19:55   ` David Miller
2012-05-17 20:04     ` Willy Tarreau
2012-05-17 20:07       ` David Miller
2012-05-17 20:41 ` Eric Dumazet
2012-05-17 21:14   ` Willy Tarreau
2012-05-17 21:40     ` Eric Dumazet
2012-05-17 21:50       ` Eric Dumazet
2012-05-17 21:57         ` Willy Tarreau
2012-05-17 22:01         ` Eric Dumazet
2012-05-17 22:10           ` Eric Dumazet
2012-05-17 22:16           ` Willy Tarreau
2012-05-17 22:22             ` Eric Dumazet
2012-05-17 22:24               ` Willy Tarreau
2012-05-17 22:25                 ` David Miller
2012-05-17 22:30                   ` Willy Tarreau
2012-05-17 22:35                     ` David Miller
2012-05-17 22:49                       ` Willy Tarreau
2012-05-17 22:27               ` Joe Perches
2012-05-17 21:54       ` Willy Tarreau
2012-05-17 21:47     ` Willy Tarreau
2012-05-17 22:14     ` Eric Dumazet
2012-05-17 22:29       ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337276056.3403.37.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox