public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: Denys Fedoryshchenko <denys@visp.net.lb>, netdev@vger.kernel.org
Subject: Re: Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e
Date: Fri, 25 May 2012 19:18:15 +0200	[thread overview]
Message-ID: <1337966295.3347.57.camel@edumazet-glaptop> (raw)
In-Reply-To: <CA+mtBx8fpS_w7X2iq+tOEFuFhhgJ-4V_1ubBsd8-MvvmCef45w@mail.gmail.com>

On Fri, 2012-05-25 at 09:59 -0700, Tom Herbert wrote:
> > TX completion has no budget, I am not sure what you mean.
> >
> Right, it's the budget on RX that can be a factor.  TX completion is
> done from the NAPI poll routine, so if RX does not complete the NAPI
> is rescheduled and TX completion is done again for the same HW
> interrupt.
> 
> We need to remove the constraint that netdev_completed can only be
> called once per interrupt...

Not clear where is this constraint in the code.

Under heavy load, we can be in a loop situation, one cpu serving NAPI
for a bunch of devices (no more hardware interrupts are delivered since
we dont re-enable them at all)

  reply	other threads:[~2012-05-25 17:18 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 14:15 Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e Denys Fedoryshchenko
2012-05-17 13:42 ` Denys Fedoryshchenko
2012-05-17 16:54   ` Denys Fedoryshchenko
2012-05-18 14:04     ` Denys Fedoryshchenko
2012-05-19  2:07       ` Tom Herbert
2012-05-19  2:29         ` Denys Fedoryshchenko
2012-05-19  2:40         ` Denys Fedoryshchenko
2012-05-20 17:40           ` Tom Herbert
2012-05-20 18:53             ` Denys Fedoryshchenko
2012-05-20 19:07               ` Eric Dumazet
2012-05-20 19:18                 ` Denys Fedoryshchenko
2012-05-21  3:56                   ` Eric Dumazet
2012-05-21  8:06                     ` Denys Fedoryshchenko
2012-05-21  8:30                       ` Eric Dumazet
2012-05-21  8:40                         ` Eric Dumazet
2012-05-21  9:22                           ` Denys Fedoryshchenko
2012-05-22 17:11                           ` Denys Fedoryshchenko
2012-05-22 17:24                             ` Eric Dumazet
2012-05-25  6:01                               ` Tom Herbert
2012-05-25  6:22                                 ` Eric Dumazet
2012-05-25 16:59                                   ` Tom Herbert
2012-05-25 17:18                                     ` Eric Dumazet [this message]
2012-05-29 14:25             ` Hiroaki SHIMODA
2012-05-29 14:54               ` Tom Herbert
2012-05-29 15:11                 ` Eric Dumazet
2012-05-29 19:52                 ` Denys Fedoryshchenko
2012-05-30  0:06                 ` Hiroaki SHIMODA
2012-05-30  8:40                   ` Eric Dumazet
2012-05-30 10:43                     ` Hiroaki SHIMODA
2012-05-30 11:08                       ` Eric Dumazet
2012-05-30 11:20                         ` Joe Perches
2012-05-30 11:59                           ` Eric Dumazet
2012-05-30 14:09                             ` Joe Perches
2012-05-30 14:42                               ` Eric Dumazet
2012-05-30 14:50                                 ` Joe Perches
2012-05-30 11:29                         ` Hiroaki SHIMODA
2012-05-30 14:49                           ` Eric Dumazet
2012-05-30 15:00                             ` dave taht
2012-05-30 22:19                             ` Hiroaki SHIMODA
2012-05-30 10:52                     ` David Laight
2012-05-30 11:04                       ` Eric Dumazet
2012-05-30 11:12                         ` Eric Dumazet
2012-06-06  5:10               ` Eric Dumazet
2012-06-06  8:43                 ` Hiroaki SHIMODA
2012-06-06 16:26                   ` Jesse Brandeburg
2012-06-06 17:05                     ` Eric Dumazet
2012-06-06 17:26                       ` David Miller
2012-06-06 17:19                     ` Hiroaki SHIMODA
2012-06-06 18:21                       ` Tom Herbert
2012-06-06 18:23                         ` David Miller
2012-06-06 18:46                           ` Stephen Hemminger
2012-05-20 18:13       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337966295.3347.57.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=denys@visp.net.lb \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox