From: Eric Dumazet <eric.dumazet@gmail.com>
To: Arun Sharma <asharma@fb.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: compute a more reasonable default ip6_rt_max_size
Date: Sun, 27 May 2012 15:18:28 +0200 [thread overview]
Message-ID: <1338124708.3670.11.camel@edumazet-glaptop> (raw)
In-Reply-To: <4FC1A57A.7080807@fb.com>
On Sat, 2012-05-26 at 20:54 -0700, Arun Sharma wrote:
> On 5/25/12 8:39 PM, Eric Dumazet wrote:
> >
> > But your patch is not a "modest increase", so whats the deal ?
> >
> > A modest increase would be 8192 instead of 4096, regardless of RAM size.
> >
>
> Yes - 8192 solves our immediate problem, but I was worrying that the
> problem might resurface as ipv6 adoption becomes more widespread.
>
Going from 4096 to 8192 is modest increase. If you put 65536, it should
be enough for the next years.
Your patch was increasing 4096 to 524288 (for 2GB of ram), which sounds
not modest at all.
> We were testing a pre-3.0 kernel that didn't have Dave's DST_NOCOUNT
> patch. Will retest with that patch applied.
Good
>
> > More over, a boot parameter to tweak it is absolutely not needed
>
> Agreed. Will remove that part.
>
> Still not sure why you'd like to go for one size regardless of
> totalram_pages.
Because size of IPv6 route table is not depending on RAM size, but on
number or IPv6 routes.
A router runs a piece of software complex enough to be able to adjust
the limit when needed, don't you think so ?
Your patch basically removes the whole idea of having a limit in the
first place. Why do we have a limit if you set it to four order of
magnitudes bigger than necessary ?
next prev parent reply other threads:[~2012-05-27 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 20:15 [PATCH] net: compute a more reasonable default ip6_rt_max_size Arun Sharma
2012-05-25 20:26 ` David Miller
2012-05-25 20:47 ` Eric Dumazet
2012-05-25 22:22 ` Arun Sharma
2012-05-25 22:51 ` David Miller
2012-05-26 0:08 ` Arun Sharma
2012-05-26 0:11 ` David Miller
2012-05-26 0:44 ` Arun Sharma
2012-05-26 3:39 ` Eric Dumazet
2012-05-26 4:17 ` Eric Dumazet
2012-05-27 3:54 ` Arun Sharma
2012-05-27 13:18 ` Eric Dumazet [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-30 23:50 Lubashev, Igor
2012-06-04 19:04 ` Lubashev, Igor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338124708.3670.11.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=asharma@fb.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).