From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jack Stone <jwjstone@fastmail.fm>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: at net/ipv4/tcp.c:1610 tcp_recvmsg+0xb1b/0xc70()
Date: Sun, 27 May 2012 21:46:11 +0200 [thread overview]
Message-ID: <1338147971.3786.55.camel@edumazet-glaptop> (raw)
In-Reply-To: <1338147374.3786.43.camel@edumazet-glaptop>
On Sun, 2012-05-27 at 21:36 +0200, Eric Dumazet wrote:
> pied elsewhere, so we can double check.
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 3ba605f..22e4c9a 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1606,8 +1606,10 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
> if (tcp_hdr(skb)->fin)
> goto found_fin_ok;
> WARN(!(flags & MSG_PEEK),
> - "recvmsg bug 2: copied %X seq %X rcvnxt %X fl %X\n",
> - *seq, TCP_SKB_CB(skb)->seq, tp->rcv_nxt, flags);
> + "recvmsg bug 2: copied %X seq %X end_seq %X rcvnxt %X fl %X offset %u len %u syn %d tcp_flags %X\n",
> + *seq, TCP_SKB_CB(skb)->seq, TCP_SKB_CB(skb)->end_seq,
> + tp->rcv_nxt, flags, offset, skb->len, tcp_hdr(skb)->syn,
> + TCP_SKB_CB(skb)->tcp_flags);
> }
>
> /* Well, if we have backlog, try to process it now yet. */
>
Oh well, ignore this, as tcp_flags is only set in output path.
next prev parent reply other threads:[~2012-05-27 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 20:25 WARNING: at net/ipv4/tcp.c:1610 tcp_recvmsg+0xb1b/0xc70() Jack Stone
2012-05-25 20:45 ` Eric Dumazet
2012-05-25 20:55 ` Eric Dumazet
2012-05-25 21:31 ` Jack Stone
2012-05-26 11:22 ` Jack Stone
2012-05-27 13:59 ` Eric Dumazet
2012-05-27 15:34 ` Jack Stone
2012-05-27 17:35 ` Eric Dumazet
2012-05-27 19:13 ` Jack Stone
2012-05-27 19:36 ` Eric Dumazet
2012-05-27 19:46 ` Eric Dumazet [this message]
2012-05-28 0:25 ` Eric Dumazet
2012-05-28 8:34 ` Jack Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338147971.3786.55.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jwjstone@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox