From: Eric Dumazet <eric.dumazet@gmail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] skb: avoid unnecessary reallocations in __skb_cow
Date: Tue, 29 May 2012 15:26:07 +0200 [thread overview]
Message-ID: <1338297967.2840.31.camel@edumazet-glaptop> (raw)
In-Reply-To: <4FC4CAB1.8010000@openwrt.org>
On Tue, 2012-05-29 at 15:10 +0200, Felix Fietkau wrote:
> I don't have any real use case in mind, but it's not really adding an
> extra NET_SKB_PAD, it simply fills up the headroom to NET_SKB_PAD,
This is not what is doing your patch.
If cloned is true, and current skb headroom less than 64, you add an
extra 64 bytes of headroom.
Just keep it simple, this is inline code and should be kept as small as
possible.
prev parent reply other threads:[~2012-05-29 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 15:26 [RFC] skb: avoid unnecessary reallocations in __skb_cow Felix Fietkau
2012-05-29 12:34 ` Eric Dumazet
2012-05-29 12:41 ` Felix Fietkau
2012-05-29 12:59 ` Eric Dumazet
2012-05-29 13:10 ` Felix Fietkau
2012-05-29 13:26 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338297967.2840.31.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox