From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: Strange latency spikes/TX network stalls on Sun Fire X4150(x86) and e1000e Date: Wed, 30 May 2012 07:50:11 -0700 Message-ID: <1338389411.32113.25.camel@joe2Laptop> References: <668eeb0d42a1678d9083a58deb3ac40d@visp.net.lb> <88c43001441945e1431609db252b69e7@visp.net.lb> <79d6b56fdf5f4be4656079568d5a7445@visp.net.lb> <20120529232518.e5b41759.shimoda.hiroaki@gmail.com> <20120530090602.6204d857.shimoda.hiroaki@gmail.com> <1338367231.2760.125.camel@edumazet-glaptop> <20120530194355.92bf5d51.shimoda.hiroaki@gmail.com> <1338376107.2760.156.camel@edumazet-glaptop> <1338376817.32113.5.camel@joe2Laptop> <1338379151.2760.166.camel@edumazet-glaptop> <1338386973.32113.23.camel@joe2Laptop> <1338388974.2760.193.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Denys Fedoryshchenko , e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org, jesse.brandeburg@intel.com, davem@davemloft.net, Tom Herbert To: Eric Dumazet Return-path: In-Reply-To: <1338388974.2760.193.camel@edumazet-glaptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Wed, 2012-05-30 at 16:42 +0200, Eric Dumazet wrote: > On Wed, 2012-05-30 at 07:09 -0700, Joe Perches wrote: > > > Whatever evals A and B once would be better. > > Why do you believe they could be evaluated several time ? > > #define POSDIFF(A, B) max_t(int, (A) - (B), 0) I don't and didn't say I did. > By the way, we handle 32bit values here. No way BQL can overflow a 4GB > limit. swell. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired