From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH (net.git) 3/3] stmmac: fix driver Kconfig when built as module Date: Mon, 4 Jun 2012 17:45:28 +0100 Message-ID: <1338828328.3979.208.camel@deadeye> References: <1338827531-10376-1-git-send-email-peppe.cavallaro@st.com> <1338827531-10376-4-git-send-email-peppe.cavallaro@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , Rayagond Kokatanur To: Giuseppe CAVALLARO Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:27760 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751989Ab2FDQpe (ORCPT ); Mon, 4 Jun 2012 12:45:34 -0400 In-Reply-To: <1338827531-10376-4-git-send-email-peppe.cavallaro@st.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2012-06-04 at 18:32 +0200, Giuseppe CAVALLARO wrote: > This patches fixes the driver when built as dyn module. > In fact the platform part cannot be built and the probe fails > (thanks to Bob Liu that reported this bug). > > v2: as D. Miller suggested, it is not necessary to make the > pci and the platform code mutually exclusive. > Having both could also help, at built time ,to verify that > all the code is validated and compiles fine. > > Reported-by: Bob Liu > Signed-off-by: Giuseppe Cavallaro > Reviewed-by: Ben Hutchings [...] What I said in <1337687765.11796.11.camel@deadeye> was: That's because CONFIG_STMMAC_PLATFORM and CONFIG_STMMAC_PCI are wrongly declared as tristate in Kconfig. Change them to bool and it should work again. You can't add a 'Reviewed-by' line on the basis of this; you can only add it if a reviewer writes that line themselves (and if you don't make further changes). Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.