netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] Remove casts to same type
Date: Mon, 04 Jun 2012 21:54:29 -0700	[thread overview]
Message-ID: <1338872069.20167.7.camel@joe2Laptop> (raw)
In-Reply-To: <CAJfuBxzVLzQK_d=JqJVzQnzHWZDtAJMihkEXWh7xeimMq9FHxQ@mail.gmail.com>

On Mon, 2012-06-04 at 22:48 -0600, Jim Cromie wrote:
> On Mon, Jun 4, 2012 at 4:44 PM, Joe Perches <joe@perches.com> wrote:
> > Adding casts of objects to the same type is unnecessary
> > and confusing for a human reader.
> > Remove them via coccinelle script.
> Can you also post the coccinelle script ?

Hi Jim.

I did that with each patch, but here it is again:

$ cat norecast.cocci
@@
type T;
T *p;
@@

-       (T *)p
+       p
$

> did you have to edit them any futher, or is it 100% script ?

Also from each patch:

I manually removed the conversions this script produces of
casts with __force, __iomem and __user.

Also, I did delete a few unnecessary parentheses left over
after the casts were removed.

  reply	other threads:[~2012-06-05  4:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04 22:44 [PATCH net-next 0/3] Remove casts to same type Joe Perches
2012-06-04 22:44 ` [PATCH net-next 1/3] ethernet: " Joe Perches
2012-06-04 22:44 ` [PATCH net-next 2/3] wireless: " Joe Perches
2012-06-04 22:44 ` [PATCH net-next 3/3] drivers: net: " Joe Perches
2012-06-05  4:48 ` [PATCH net-next 0/3] " Jim Cromie
2012-06-05  4:54   ` Joe Perches [this message]
2012-06-06 16:33 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338872069.20167.7.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=jim.cromie@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).