From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next v2 1/2] inetpeer: add namespace support for inetpeer Date: Tue, 05 Jun 2012 14:18:14 +0200 Message-ID: <1338898694.2760.2478.camel@edumazet-glaptop> References: <1338882737-11914-1-git-send-email-gaofeng@cn.fujitsu.com> <1338886626.2760.2109.camel@edumazet-glaptop> <20120605112728.GB27795@secunet.com> <1338897630.2760.2433.camel@edumazet-glaptop> <20120605121510.GD27795@secunet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org To: Steffen Klassert Return-path: In-Reply-To: <20120605121510.GD27795-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, 2012-06-05 at 14:15 +0200, Steffen Klassert wrote: > Lookups are done under rcu, yes. But a lookup will not find > these stale entries because the whole interpeer tree is removed > from the inetpeer base before the worker is scheduled. A lookup > would have to cerate a new inetpeer entry in this case. > Thats simply not true. You don't respect basic RCU rules. Please read them.