From: Jan Ceuleers <jan.ceuleers@computer.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: Jiajun Wu <b06378@freescale.com>, Joe Perches <joe@perches.com>,
netdev@vger.kernel.org
Subject: [PATCH v3 net-next 0/5] gianfar: coding style cleanups
Date: Tue, 5 Jun 2012 15:42:10 +0200 [thread overview]
Message-ID: <1338903735-24527-1-git-send-email-jan.ceuleers@computer.org> (raw)
Various coding style cleanups, mostly whitespace and comment reformatting.
I have left a number of lines untouched where I felt that the changes I
was considering were not improving readability. But de gustibus etc.
Patch 4/5 also removes some superfluous local variable initialisations.
These are obviously correct because the variable is initialised again
right after. But you might consider this to be unnecessary code churn
because the compiler is unlikely to generate better code due to this patch.
WARNING: Compile-tested only. I do not have the hardware.
This is my first patch _series_ submission; please be kind.
v3: no changes from v2, except now compile-tested using powerpc crosstool
v2: fixed typo in 5/5 (found by David)
Jan Ceuleers (5):
gianfar: whitespace cleanup - pointers and multiplications
gianfar: comment cleanup
gianfar: various coding style and whitespace cleanups
gianfar: Remove superfluous initialisations
gianfar_ethtool: coding style and whitespace cleanups
drivers/net/ethernet/freescale/gianfar.c | 491 +++++++++++-----------
drivers/net/ethernet/freescale/gianfar_ethtool.c | 420 +++++++++---------
2 files changed, 479 insertions(+), 432 deletions(-)
--
1.7.9.5
next reply other threads:[~2012-06-05 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 13:42 Jan Ceuleers [this message]
2012-06-05 13:42 ` [PATCH v3 net-next 1/5] gianfar: whitespace cleanup - pointers and multiplications Jan Ceuleers
2012-06-05 13:42 ` [PATCH v3 net-next 2/5] gianfar: comment cleanup Jan Ceuleers
2012-06-05 13:42 ` [PATCH v3 net-next 3/5] gianfar: various coding style and whitespace cleanups Jan Ceuleers
2012-06-05 13:42 ` [PATCH v3 net-next 4/5] gianfar: Remove superfluous initialisations Jan Ceuleers
2012-06-05 13:42 ` [PATCH v3 net-next 5/5] gianfar_ethtool: coding style and whitespace cleanups Jan Ceuleers
2012-06-05 22:38 ` [PATCH v3 net-next 0/5] gianfar: coding style cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338903735-24527-1-git-send-email-jan.ceuleers@computer.org \
--to=jan.ceuleers@computer.org \
--cc=b06378@freescale.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).