From: Eric Dumazet <eric.dumazet@gmail.com>
To: Grant Edwards <grant.b.edwards@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: Change in alloc_skb() behavior in 3.2+ kernels?
Date: Thu, 07 Jun 2012 16:01:50 +0200 [thread overview]
Message-ID: <1339077710.5083.12.camel@edumazet-glaptop> (raw)
In-Reply-To: <jqqa1b$kug$1@dough.gmane.org>
On Thu, 2012-06-07 at 13:23 +0000, Grant Edwards wrote:
> On 2012-06-06, David Miller <davem@davemloft.net> wrote:
> > From: Grant Edwards <grant.b.edwards@gmail.com>
> > Date: Wed, 6 Jun 2012 18:59:19 +0000 (UTC)
> >
> >> At the time it was written (probably 10+ years ago) it was relying on
> >> the documented API for alloc_skb() that stated alloc_skb() either
> >> returned an sk_buff of the requested size or it failed.
> >
> > It was never a formal API that we would only allocate 'size'
> > amount of tailroom.
>
> How can you say that?
Documentation was stale, so what ?
kmalloc(99) doesnt allocate 99 bytes but 128, so what ?
Grant, what about you fix your code ?
next prev parent reply other threads:[~2012-06-07 14:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 18:32 Change in alloc_skb() behavior in 3.2+ kernels? Grant Edwards
2012-06-06 18:42 ` Eric Dumazet
2012-06-06 18:59 ` Grant Edwards
2012-06-06 19:02 ` David Miller
2012-06-06 20:22 ` Grant Edwards
2012-06-07 1:23 ` [PATCH net-next] net: Update kernel-doc for __alloc_skb() Ben Hutchings
2012-06-07 20:19 ` David Miller
2012-06-07 13:23 ` Change in alloc_skb() behavior in 3.2+ kernels? Grant Edwards
2012-06-07 14:01 ` Eric Dumazet [this message]
2012-06-07 14:16 ` Grant Edwards
2012-06-07 14:25 ` Eric Dumazet
2012-06-06 18:51 ` David Miller
2012-06-06 19:01 ` Grant Edwards
2012-06-06 20:17 ` David Miller
2012-06-06 20:24 ` Grant Edwards
2012-06-06 20:31 ` Eric Dumazet
2012-06-06 20:35 ` Grant Edwards
2012-06-06 19:42 ` Eric Dumazet
2012-06-06 20:26 ` Grant Edwards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339077710.5083.12.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=grant.b.edwards@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox