From: Roman Kagan <rkagan@parallels.com>
To: Greg KH <greg@kroah.com>
Cc: David Miller <davem@davemloft.net>,
"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
"tarbal@gmail.com" <tarbal@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"jesse.brandeburg@intel.com" <jesse.brandeburg@intel.com>,
"bruce.w.allan@intel.com" <bruce.w.allan@intel.com>,
"carolyn.wyborny@intel.com" <carolyn.wyborny@intel.com>,
"donald.c.skidmore@intel.com" <donald.c.skidmore@intel.com>,
"gregory.v.rose@intel.com" <gregory.v.rose@intel.com>,
"peter.p.waskiewicz.jr@intel.com"
<peter.p.waskiewicz.jr@intel.com>,
"alexander.h.duyck@intel.com" <alexander.h.duyck@intel.com>,
"john.ronciak@intel.com" <john.ronciak@intel.com>,
"dnelson@redhat.com" <dnelson@redhat.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.or
Subject: Re: [PATCH] e1000: save skb counts in TX to avoid cache misses
Date: Fri, 8 Jun 2012 11:37:22 +0400 [thread overview]
Message-ID: <1339141042.7850.51.camel@rkaganb.sw.ru> (raw)
In-Reply-To: <20120608021542.GA10112@kroah.com>
On Fri, 2012-06-08 at 06:15 +0400, Greg KH wrote:
> On Thu, Jun 07, 2012 at 02:43:58PM -0700, David Miller wrote:
> > From: Jeff Kirsher <tarbal@gmail.com>
> > Date: Thu, 07 Jun 2012 14:38:17 -0700
> >
> > > Thanks! I have applied the patch to my queue
> >
> > Why?
> >
> > My impression is that this is a patch already in the tree, and it's
> > being submitted for -stable but such minor performance hacks are
> > absolutely not appropriate for -stable submission.
>
> The patch description says it is fixing reported oopses,
Exactly.
> but the Subject: isn't all that helpful there.
Well I just preserved the original subject from the upstream commit.
Want me to resubmit with a more alarming one?
> So which is this? Should I accept it for a stable release or not?
IMO yes ;)
Thanks,
Roman.
next prev parent reply other threads:[~2012-06-08 7:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 12:49 [PATCH] e1000: save skb counts in TX to avoid cache misses Roman Kagan
2012-06-07 21:38 ` Jeff Kirsher
2012-06-07 21:43 ` David Miller
2012-06-07 22:02 ` Jeff Kirsher
2012-06-08 2:15 ` Greg KH
2012-06-08 7:37 ` Roman Kagan [this message]
2012-06-13 11:12 ` Roman Kagan
2012-06-14 22:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339141042.7850.51.camel@rkaganb.sw.ru \
--to=rkagan@parallels.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=dnelson@redhat.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.or \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=stable@vger.kernel.org \
--cc=tarbal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox