From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: Fix corrupted queue_mapping
Date: Fri, 08 Jun 2012 09:46:37 +0200 [thread overview]
Message-ID: <1339141597.6001.47.camel@edumazet-glaptop> (raw)
In-Reply-To: <1339140238.6001.42.camel@edumazet-glaptop>
On Fri, 2012-06-08 at 09:24 +0200, Eric Dumazet wrote:
>
> I must say I dont understand dev_pick_tx() anymore.
>
> It seems to ignore skb->queue_mapping (unless device provides its own
> ndo_select_queue() and this functions is aware of skb->queue_mapping, as
> correctly done in ixgbe)
>
> So commit fff3269907897ee (tcp: reflect SYN queue_mapping into SYNACK
> packets) works on ixgbe, but probably not on other multiqueue devices.
>
> This sounds like a regression to me.
Oh well, its done in skb_tx_hash(), after a few indirections, and if
skb->sk is NULL.
Which happens to be true in net-next for SYNACKS after commit
90ba9b1986b5ac (tcp: tcp_make_synack() can use alloc_skb())
next prev parent reply other threads:[~2012-06-08 7:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 5:05 [PATCH] bonding: Fix corrupted queue_mapping Tom Herbert
2012-06-08 5:46 ` David Miller
2012-06-08 5:57 ` Eric Dumazet
2012-06-08 6:02 ` David Miller
2012-06-08 6:11 ` Eric Dumazet
2012-06-08 6:15 ` David Miller
2012-06-08 6:47 ` Eric Dumazet
2012-06-08 7:23 ` Eric Dumazet
2012-06-08 7:42 ` John Fastabend
2012-06-08 7:48 ` Eric Dumazet
2012-06-08 7:52 ` Eric Dumazet
2012-06-08 7:46 ` Eric Dumazet [this message]
2012-06-08 15:04 ` Tom Herbert
2012-06-08 15:11 ` Eric Dumazet
2012-06-08 16:16 ` John Fastabend
2012-06-08 6:17 ` Eric Dumazet
2012-06-08 6:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339141597.6001.47.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox