From: Ben Hutchings <bhutchings@solarflare.com>
To: Matthew Shaw <shaw500@gmail.com>
Cc: <davem@emloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: socket: fixed coding style issues.
Date: Mon, 11 Jun 2012 18:53:23 +0100 [thread overview]
Message-ID: <1339437203.2665.8.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <1339420656-11512-1-git-send-email-shaw500@gmail.com>
On Mon, 2012-06-11 at 14:17 +0100, Matthew Shaw wrote:
> Fixed an instance where brances are used but not needed, and some lines
> in the comments and code that exceed the 80 character limit.
>
> Signed-off-by: Matthew Shaw <shaw500@gmail.com>
> ---
> net/socket.c | 137 ++++++++++++++++++++++++++++++++--------------------------
> 1 file changed, 75 insertions(+), 62 deletions(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index 6e0ccc0..2133040 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -8,48 +8,48 @@
> * Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
> *
> * Fixes:
> - * Anonymous : NOTSOCK/BADF cleanup. Error fix in
> - * shutdown()
> - * Alan Cox : verify_area() fixes
> - * Alan Cox : Removed DDI
> - * Jonathan Kamens : SOCK_DGRAM reconnect bug
[...]
I would question whether such lists of bug fixes are worth keeping at
all. The names should probably be kept as credits, but the details are
ancient history now.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-06-11 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 13:17 [PATCH] net: socket: fixed coding style issues Matthew Shaw
2012-06-11 17:53 ` Ben Hutchings [this message]
2012-06-11 18:03 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339437203.2665.8.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@emloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shaw500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox