From: Eric Dumazet <eric.dumazet@gmail.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
rayagond@vayavyalabs.com, davem@davemloft.net,
yuvalmin@broadcom.com
Subject: Re: [net-next.git 2/4] stmmac: do not use strict_strtoul but kstrtoul
Date: Tue, 12 Jun 2012 16:28:01 +0200 [thread overview]
Message-ID: <1339511281.22704.156.camel@edumazet-glaptop> (raw)
In-Reply-To: <1339505153-26731-3-git-send-email-peppe.cavallaro@st.com>
On Tue, 2012-06-12 at 14:45 +0200, Giuseppe CAVALLARO wrote:
> This patch replaces the obsolete strict_strtoul with kstrtoul.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 26 ++++++++-------------
> 1 files changed, 10 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 8899e10..e33abf5 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2126,42 +2126,36 @@ static int __init stmmac_cmdline_opt(char *str)
> return -EINVAL;
> while ((opt = strsep(&str, ",")) != NULL) {
> if (!strncmp(opt, "debug:", 6)) {
> - if (strict_strtoul(opt + 6, 0, (unsigned long *)&debug))
> + if (kstrtoul(opt + 6, 0, (unsigned long *)&debug))
> goto err;
int debug;
...
if (kstrtoul(opt + 6, 0, (unsigned long *)&debug))
Please get rid of these wrong casts.
next prev parent reply other threads:[~2012-06-12 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 12:45 [net-next.git 0/4] EEE for PAL and stmmac Giuseppe CAVALLARO
2012-06-12 12:45 ` [net-next.git 1/4 (v4)] phy: add the EEE support and the way to access to the MMD registers Giuseppe CAVALLARO
2012-06-12 16:50 ` Ben Hutchings
2012-06-12 12:45 ` [net-next.git 2/4] stmmac: do not use strict_strtoul but kstrtoul Giuseppe CAVALLARO
2012-06-12 14:28 ` Eric Dumazet [this message]
2012-06-12 12:45 ` [net-next.git 3/4] stmmac: update the driver Documentation and add EEE Giuseppe CAVALLARO
2012-06-12 12:45 ` [net-next.git 4/4 (v4)] stmmac: add the Energy Efficient Ethernet support Giuseppe CAVALLARO
2012-06-12 13:09 ` Yuval Mintz
2012-06-12 14:24 ` Giuseppe CAVALLARO
2012-06-12 16:42 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339511281.22704.156.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox