From: Sasha Levin <levinsasha928@gmail.com>
To: johannes.berg@intel.com, wey-yi.w.guy@intel.com, linville@tuxdriver.com
Cc: ilw@linux.intel.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sasha Levin <levinsasha928@gmail.com>
Subject: [PATCH] iwlwifi: re-order module_init order to prevent NULL ptr deref
Date: Tue, 12 Jun 2012 21:13:32 +0200 [thread overview]
Message-ID: <1339528412-4163-1-git-send-email-levinsasha928@gmail.com> (raw)
We need to make sure iwl_drv_init is called before iwl_init, since otherwise
iwl_init will NULL ptr deref when trying to add a new mode.
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
drivers/net/wireless/iwlwifi/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile
index 98c8f64..16e39a4 100644
--- a/drivers/net/wireless/iwlwifi/Makefile
+++ b/drivers/net/wireless/iwlwifi/Makefile
@@ -1,5 +1,3 @@
-obj-$(CONFIG_IWLDVM) += dvm/
-
CFLAGS_iwl-devtrace.o := -I$(src)
# common
@@ -14,4 +12,6 @@ iwlwifi-objs += pcie/1000.o pcie/2000.o pcie/5000.o pcie/6000.o
iwlwifi-$(CONFIG_IWLWIFI_DEVICE_TRACING) += iwl-devtrace.o
+obj-$(CONFIG_IWLDVM) += dvm/
+
ccflags-y += -D__CHECK_ENDIAN__ -I$(src)
--
1.7.8.6
next reply other threads:[~2012-06-12 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 19:13 Sasha Levin [this message]
2012-06-12 19:17 ` [PATCH] iwlwifi: re-order module_init order to prevent NULL ptr deref Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339528412-4163-1-git-send-email-levinsasha928@gmail.com \
--to=levinsasha928@gmail.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).