From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Don Skidmore <donald.c.skidmore@intel.com>,
Greg Rose <gregory.v.rose@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
"David S. Miller" <davem@davemloft.net>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ixgbe: simplify padding and length checks (v2)
Date: Tue, 19 Jun 2012 16:30:51 -0700 [thread overview]
Message-ID: <1340148651.1988.33.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20120618163111.4e46493b@nehalam.linuxnetplumber.net>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Mon, 2012-06-18 at 16:31 -0700, Stephen Hemminger wrote:
> The check for length <= 0 is bogus because length is unsigned, and
> network
> stack never sends zero length packets (unless it is totally broken).
>
> The check for really small packets can be optimized (using unlikely)
> and calling skb_pad directly.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
I just realized I had not responded to this updated patch.
Thanks Stephen, I have dropped your previous 2 patch series and added
this patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-19 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 17:58 [PATCH 1/2 net-next] ixgbe: use skb_padto Stephen Hemminger
2012-06-18 18:55 ` [PATCH 2/2 net-next] ixgbe: remove xmit length check Stephen Hemminger
2012-06-18 20:39 ` Jeff Kirsher
2012-06-18 20:38 ` [PATCH 1/2 net-next] ixgbe: use skb_padto Jeff Kirsher
2012-06-18 21:18 ` Alexander Duyck
2012-06-18 23:31 ` [PATCH net-next] ixgbe: simplify padding and length checks (v2) Stephen Hemminger
2012-06-19 23:30 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340148651.1988.33.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox