* [net 1/3] igb: Fix incorrect RAR address entries for i210/i211 device.
2012-06-20 8:44 [net 0/3][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
@ 2012-06-20 8:44 ` Jeff Kirsher
2012-06-20 8:44 ` [net 2/3] Kconfig: Fix Kconfig for Intel ixgbe and igb PTP support Jeff Kirsher
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2012-06-20 8:44 UTC (permalink / raw)
To: davem; +Cc: Carolyn Wyborny, netdev, gospo, sassmann, Jeff Kirsher
From: Carolyn Wyborny <carolyn.wyborny@intel.com>
i210/i211 device has only 16 RAR address filters like 82575, instead of
32 like i350. This patch removes the entries for i210/i211 in the
get_invariants function which was setting them for 32. This ensures that
they will get the default value which is the correct one.
Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/igb/e1000_82575.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c b/drivers/net/ethernet/intel/igb/e1000_82575.c
index e650839..5e84eaa 100644
--- a/drivers/net/ethernet/intel/igb/e1000_82575.c
+++ b/drivers/net/ethernet/intel/igb/e1000_82575.c
@@ -206,8 +206,6 @@ static s32 igb_get_invariants_82575(struct e1000_hw *hw)
mac->rar_entry_count = E1000_RAR_ENTRIES_82580;
break;
case e1000_i350:
- case e1000_i210:
- case e1000_i211:
mac->rar_entry_count = E1000_RAR_ENTRIES_I350;
break;
default:
--
1.7.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [net 2/3] Kconfig: Fix Kconfig for Intel ixgbe and igb PTP support.
2012-06-20 8:44 [net 0/3][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-06-20 8:44 ` [net 1/3] igb: Fix incorrect RAR address entries for i210/i211 device Jeff Kirsher
@ 2012-06-20 8:44 ` Jeff Kirsher
2012-06-20 8:44 ` [net 3/3] ixgbe: Fix memory leak in ixgbe when receiving traffic on DDP enabled rings Jeff Kirsher
2012-06-20 22:09 ` [net 0/3][pull request] Intel Wired LAN Driver Updates David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2012-06-20 8:44 UTC (permalink / raw)
To: davem; +Cc: Carolyn Wyborny, netdev, gospo, sassmann, Jeff Kirsher
From: Carolyn Wyborny <carolyn.wyborny@intel.com>
Fix Kconfig file to make sure that PTP and IGB/IXGBE are both either
in-kernel or modules, not mixed. Having the build status mixed causes
compile errors.
Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/Kconfig | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
index 79b07ec..0cafe4f 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -122,8 +122,10 @@ config IGB_DCA
config IGB_PTP
bool "PTP Hardware Clock (PHC)"
- default y
- depends on IGB && PTP_1588_CLOCK
+ default n
+ depends on IGB && EXPERIMENTAL
+ select PPS
+ select PTP_1588_CLOCK
---help---
Say Y here if you want to use PTP Hardware Clock (PHC) in the
driver. Only the basic clock operations have been implemented.
@@ -223,7 +225,9 @@ config IXGBE_DCB
config IXGBE_PTP
bool "PTP Clock Support"
default n
- depends on IXGBE && PTP_1588_CLOCK
+ depends on IXGBE && EXPERIMENTAL
+ select PPS
+ select PTP_1588_CLOCK
---help---
Say Y here if you want support for 1588 Timestamping with a
PHC device, using the PTP 1588 Clock support. This is
--
1.7.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [net 3/3] ixgbe: Fix memory leak in ixgbe when receiving traffic on DDP enabled rings
2012-06-20 8:44 [net 0/3][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-06-20 8:44 ` [net 1/3] igb: Fix incorrect RAR address entries for i210/i211 device Jeff Kirsher
2012-06-20 8:44 ` [net 2/3] Kconfig: Fix Kconfig for Intel ixgbe and igb PTP support Jeff Kirsher
@ 2012-06-20 8:44 ` Jeff Kirsher
2012-06-20 22:09 ` [net 0/3][pull request] Intel Wired LAN Driver Updates David Miller
3 siblings, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2012-06-20 8:44 UTC (permalink / raw)
To: davem; +Cc: Alexander Duyck, netdev, gospo, sassmann, Jeff Kirsher
From: Alexander Duyck <alexander.h.duyck@intel.com>
This patch fixes a memory leak that was introduced in the 3.4 kernel. The
leak occurred when FCoE was enabled and traffic was passed over the FCoE
rings reserved for FCoE. The memory leak was due to us not populating the
compound page information on the order 1 pages needed for FCoE.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 17ad6a3..cbb05d6 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -1148,7 +1148,7 @@ static bool ixgbe_alloc_mapped_page(struct ixgbe_ring *rx_ring,
/* alloc new page for storage */
if (likely(!page)) {
- page = alloc_pages(GFP_ATOMIC | __GFP_COLD,
+ page = alloc_pages(GFP_ATOMIC | __GFP_COLD | __GFP_COMP,
ixgbe_rx_pg_order(rx_ring));
if (unlikely(!page)) {
rx_ring->rx_stats.alloc_rx_page_failed++;
--
1.7.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [net 0/3][pull request] Intel Wired LAN Driver Updates
2012-06-20 8:44 [net 0/3][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
` (2 preceding siblings ...)
2012-06-20 8:44 ` [net 3/3] ixgbe: Fix memory leak in ixgbe when receiving traffic on DDP enabled rings Jeff Kirsher
@ 2012-06-20 22:09 ` David Miller
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2012-06-20 22:09 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 20 Jun 2012 01:44:39 -0700
> This series contains fixes to igb, ixgbe and intel/Kconfig
>
> The following are changes since commit 2c995ff892313009e336ecc8ec3411022f5b1c39:
> batman-adv: fix skb->data assignment
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net master
>
> Alexander Duyck (1):
> ixgbe: Fix memory leak in ixgbe when receiving traffic on DDP enabled
> rings
>
> Carolyn Wyborny (2):
> igb: Fix incorrect RAR address entries for i210/i211 device.
> Kconfig: Fix Kconfig for Intel ixgbe and igb PTP support.
Pulled, thanks Jeff.
^ permalink raw reply [flat|nested] 5+ messages in thread