From: Joe Perches <joe@perches.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, eilong@broadcom.com,
Yaniv Rosner <yaniv.rosner@broadcom.com>
Subject: Re: [PATCH net-next 2/6] bnx2x: link cleanup
Date: Wed, 20 Jun 2012 07:53:39 -0700 [thread overview]
Message-ID: <1340204019.29885.9.camel@joe2Laptop> (raw)
In-Reply-To: <1340182175-916-3-git-send-email-yuvalmin@broadcom.com>
On Wed, 2012-06-20 at 11:49 +0300, Yuval Mintz wrote:
> This patch does several things:
[]
> 3. Change msleep(1) --> usleep_range(1000, 1000)
I believe replacing msleep(small) with
usleep_range(small * 1000, small * 1000) is
not generally a good idea.
Please give usleep_range an actual range to
work with and not a repeated single value.
Please think a little more about what a
good upper range for the maximum time to
sleep should be.
usleep_range(small * 1000, small * 2000)
or something similar maybe.
next prev parent reply other threads:[~2012-06-20 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 8:49 [PATCH net-next 0/6] bnx2x: link patch series Yuval Mintz
2012-06-20 8:49 ` [PATCH net-next 1/6] bnx2x: sfp+ Tx fault detection added Yuval Mintz
2012-06-20 8:49 ` [PATCH net-next 2/6] bnx2x: link cleanup Yuval Mintz
2012-06-20 14:53 ` Joe Perches [this message]
2012-06-20 17:50 ` Yuval Mintz
2012-06-20 22:41 ` Joe Perches
2012-06-20 8:49 ` [PATCH net-next 3/6] bnx2x: treat 0 speed as link down (copper) Yuval Mintz
2012-06-20 8:49 ` [PATCH net-next 4/6] bnx2x: revised link register access Yuval Mintz
2012-06-20 8:49 ` [PATCH net-next 5/6] bnx2x: 1G sfp+ module handling Yuval Mintz
2012-06-20 8:49 ` [PATCH net-next 6/6] bnx2x: link module eeprom Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340204019.29885.9.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yaniv.rosner@broadcom.com \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).