From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
netdev@vger.kernel.org, davem@davemloft.net,
jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] net: Update netdev_alloc_frag to work more efficiently with TCP and GRO
Date: Thu, 21 Jun 2012 07:07:06 +0200 [thread overview]
Message-ID: <1340255226.4604.3774.camel@edumazet-glaptop> (raw)
In-Reply-To: <4FE29DE4.1010705@gmail.com>
On Wed, 2012-06-20 at 21:07 -0700, Alexander Duyck wrote:
> On 6/20/2012 6:21 AM, Eric Dumazet wrote:
> > + nc->page = alloc_pages(GFP_ATOMIC | __GFP_COLD |
> > + (NETDEV_FRAG_ORDER ? __GFP_COMP : 0),
> > + NETDEV_FRAG_ORDER);
> I was wondering if you needed the check for NETDEV_FRAG_ORDER here.
> From what I can tell setting __GFP_COMP for an order 0 page has no
> effect since it only seems to get checked in prep_new_page and that is
> after a check to verify if the page is order 0 or not.
Good point, it seems some net drivers could be changed to remove
useless tests.
I'll post some performance data as well.
next prev parent reply other threads:[~2012-06-21 5:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 0:43 [PATCH] net: Update netdev_alloc_frag to work more efficiently with TCP and GRO Alexander Duyck
2012-06-20 1:49 ` Alexander Duyck
2012-06-20 5:36 ` Eric Dumazet
2012-06-20 8:17 ` Eric Dumazet
2012-06-20 8:44 ` Eric Dumazet
2012-06-20 9:04 ` David Miller
2012-06-20 9:14 ` Eric Dumazet
2012-06-20 13:21 ` Eric Dumazet
2012-06-21 4:07 ` Alexander Duyck
2012-06-21 5:07 ` Eric Dumazet [this message]
2012-06-22 12:33 ` Eric Dumazet
2012-06-23 0:17 ` Alexander Duyck
2012-06-29 23:04 ` Alexander Duyck
2012-06-30 8:39 ` Eric Dumazet
2012-06-21 5:56 ` David Miller
2012-06-20 16:30 ` Alexander Duyck
2012-06-20 17:14 ` Alexander Duyck
2012-06-20 18:41 ` Eric Dumazet
2012-06-20 20:10 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340255226.4604.3774.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox