From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dmitry Kravkov <dmitry@broadcom.com>
Cc: Tomas Hruby <thruby@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"therbert@google.com" <therbert@google.com>,
"evansr@google.com" <evansr@google.com>,
Eilon Greenstein <eilong@broadcom.com>,
Merav Sicron <meravs@broadcom.com>,
Yaniv Rosner <yaniv.rosner@broadcom.com>,
"willemb@google.com" <willemb@google.com>
Subject: Re: [PATCH] bnx2x: fix panic when TX ring is full
Date: Thu, 21 Jun 2012 17:12:06 +0200 [thread overview]
Message-ID: <1340291526.4604.5710.camel@edumazet-glaptop> (raw)
In-Reply-To: <1340281166.15484.16.camel@lb-tlvb-dmitry>
On Thu, 2012-06-21 at 15:19 +0300, Dmitry Kravkov wrote:
> The crash happens with default configuration since
> [4acb41903b2f99f3dffd4c3df9acc84ca5942cb2] "net/tcp: Fix tcp memory
> limits initialization when !CONFIG_SYSCTL", but it can be hit by
> increasing values of tcp_wmem even earlier.
This makes no sense.
> From: Dmitry Kravkov <dmitry@broadcom.com>
> Subject: [PATCH net-next] bnx2x: reservation for NEXT tx BDs
>
> Commit [4acb41903b2f99f3dffd4c3df9acc84ca5942cb2]
> net/tcp: Fix tcp memory limits initialization when !CONFIG_SYSCTL
> provided new default value for tcp_wmem, since heavy tcp
> traffic may cause the TSO packet to consume 20 BDs + 1 for next page
> descriptor.
This is completely bogus. I have no idea how you came to this.
A forwarding workload can trigger same bug, if GRO is enabled.
Remove this wrong bit, please ?
next prev parent reply other threads:[~2012-06-21 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 19:45 [PATCH] bnx2x: fix panic when TX ring is full Eric Dumazet
2012-06-15 22:30 ` David Miller
2012-06-16 7:40 ` Dmitry Kravkov
2012-06-18 7:38 ` Eric Dumazet
2012-06-18 17:18 ` Tomas Hruby
2012-06-18 18:07 ` Eilon Greenstein
2012-06-21 12:19 ` Dmitry Kravkov
2012-06-21 15:12 ` Eric Dumazet [this message]
2012-06-21 15:56 ` Dmitry Kravkov
2012-06-21 16:01 ` Dmitry Kravkov
2012-06-21 16:25 ` Eric Dumazet
2012-06-21 16:34 ` Dmitry Kravkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340291526.4604.5710.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=evansr@google.com \
--cc=meravs@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=thruby@google.com \
--cc=willemb@google.com \
--cc=yaniv.rosner@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox