From: Joe Perches <joe@perches.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, eilong@broadcom.com,
Yaniv Rosner <yaniv.rosner@broadcom.com>
Subject: Re: [PATCH net-next (v2) 2/6] bnx2x: link cleanup
Date: Thu, 21 Jun 2012 10:06:25 -0700 [thread overview]
Message-ID: <1340298385.29885.76.camel@joe2Laptop> (raw)
In-Reply-To: <1340255123-22371-3-git-send-email-yuvalmin@broadcom.com>
On Thu, 2012-06-21 at 08:05 +0300, Yuval Mintz wrote:
> This patch does several things:
[]
> 3. Change msleep(small) --> usleep_range(small, small*2).
> Also correct existing calls to usleep_range.
Just fyi:
There are some more of these duplicated arg
usleep_range uses in other files too
cheers, Joe
$ grep -rP --include=*.[ch] -n "\busleep_range\s*\(\s*(\w+)\s*,\s*\1\s*\)" drivers/net/ethernet/broadcom/bnx2x/
drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c:149: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:1167: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:1202: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:1631: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:1733: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:1763: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:7845: usleep_range(1000,1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:10571: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:329: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:1411: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:8308: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:8710: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:8741: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:8774: usleep_range(1000, 1000);
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:10463: usleep_range(1000, 1000);
next prev parent reply other threads:[~2012-06-21 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 5:05 [PATCH net-next (v2) 0/6] bnx2x: link patch series Yuval Mintz
2012-06-21 5:05 ` [PATCH net-next (v2) 1/6] bnx2x: sfp+ Tx fault detection added Yuval Mintz
2012-06-21 5:05 ` [PATCH net-next (v2) 2/6] bnx2x: link cleanup Yuval Mintz
2012-06-21 17:06 ` Joe Perches [this message]
2012-06-21 17:52 ` Yuval Mintz
2012-06-21 5:05 ` [PATCH net-next (v2) 3/6] bnx2x: treat 0 speed as link down (copper) Yuval Mintz
2012-06-21 5:05 ` [PATCH net-next (v2) 4/6] bnx2x: revised link register access Yuval Mintz
2012-06-21 5:05 ` [PATCH net-next (v2) 5/6] bnx2x: 1G sfp+ module handling Yuval Mintz
2012-06-21 5:05 ` [PATCH net-next (v2) 6/6] bnx2x: link module eeprom Yuval Mintz
2012-06-23 0:20 ` [PATCH net-next (v2) 0/6] bnx2x: link patch series David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340298385.29885.76.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yaniv.rosner@broadcom.com \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).