From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Johannes Berg
<johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/6] mac80211: clean up debugging
Date: Fri, 22 Jun 2012 07:37:08 -0700 [thread overview]
Message-ID: <1340375828.31821.11.camel@joe2Laptop> (raw)
In-Reply-To: <1340370882-9258-5-git-send-email-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
On Fri, 2012-06-22 at 15:14 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> There are a few things that make the debugging
> in mac80211 painful:
> * pr_debug makes it require *both* Kconfig and
> dynamic configuration -- move to pr_info
pr_info can clutter the log.
> * the macros still need trailing newlines
That's not a bad thing.
> @@ -317,7 +318,7 @@ ieee80211_agg_splice_packets(struct ieee80211_sub_if_data *sdata,
> ieee80211_stop_queue_agg(sdata, tid);
>
> if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates"
> - " from the pending queue\n", tid))
> + " from the pending queue", tid))
defective.
Don't remove newlines in single modules.
Using a single style _with_ a newline limits defects and
limits the likely misuse in other styles.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next parent reply other threads:[~2012-06-22 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1340370882-9258-1-git-send-email-johannes@sipsolutions.net>
[not found] ` <1340370882-9258-5-git-send-email-johannes@sipsolutions.net>
[not found] ` <1340370882-9258-5-git-send-email-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2012-06-22 14:37 ` Joe Perches [this message]
2012-06-22 14:43 ` [PATCH 4/6] mac80211: clean up debugging Johannes Berg
2012-06-22 14:49 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340375828.31821.11.camel@joe2Laptop \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).