From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 4/6] mac80211: clean up debugging
Date: Fri, 22 Jun 2012 07:49:09 -0700 [thread overview]
Message-ID: <1340376549.31821.19.camel@joe2Laptop> (raw)
In-Reply-To: <1340376203.4491.29.camel@jlt3.sipsolutions.net>
On Fri, 2012-06-22 at 16:43 +0200, Johannes Berg wrote:
> > Using a single style _with_ a newline limits defects and
> > limits the likely misuse in other styles.
>
> I'd rather have double newlines once a while than missing ones. I've
> seen a lot of bugs with missing newlines, which is rather annoying.
Yeah, I have too.
It's because people add macros that add terminating
newlines and there's no style consistency.
I think you should _not_ add more macros that promote
this inconsistency.
usb's uses of err/warn/info/dbg are going away.
These should too.
prev parent reply other threads:[~2012-06-22 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1340370882-9258-1-git-send-email-johannes@sipsolutions.net>
[not found] ` <1340370882-9258-5-git-send-email-johannes@sipsolutions.net>
[not found] ` <1340370882-9258-5-git-send-email-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2012-06-22 14:37 ` [PATCH 4/6] mac80211: clean up debugging Joe Perches
2012-06-22 14:43 ` Johannes Berg
2012-06-22 14:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340376549.31821.19.camel@joe2Laptop \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).