From: Eric Dumazet <eric.dumazet@gmail.com>
To: Josh Hunt <johunt@akamai.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kaber@trash.net" <kaber@trash.net>,
Debabrata Banerjee <dbavatar@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"jmorris@namei.org" <jmorris@namei.org>,
"pekkas@netcore.fi" <pekkas@netcore.fi>,
"kuznet@ms2.inr.ac.ru" <kuznet@ms2.inr.ac.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Bug in net/ipv6/ip6_fib.c:fib6_dump_table()
Date: Fri, 22 Jun 2012 20:13:05 +0200 [thread overview]
Message-ID: <1340388785.4604.11442.camel@edumazet-glaptop> (raw)
In-Reply-To: <4FE476A6.1050209@akamai.com>
On Fri, 2012-06-22 at 08:44 -0500, Josh Hunt wrote:
> Ahh. That makes sense and is what Alexey said before I just didn't put
> it all together. So we are OK reverting this patch? I cannot find a path
> where the walker's pointers are updated without the tb6_lock write_lock.
>
There was a bug somewhere, not sure we want to NULL dereference again.
Following fix should at least avoid a never ending dump
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 74c21b9..6083276 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -1349,8 +1349,8 @@ static int fib6_walk_continue(struct fib6_walker_t *w)
if (w->leaf && fn->fn_flags & RTN_RTINFO) {
int err;
- if (w->count < w->skip) {
- w->count++;
+ if (w->skip) {
+ w->skip--;
continue;
}
next prev parent reply other threads:[~2012-06-22 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 17:22 Bug in net/ipv6/ip6_fib.c:fib6_dump_table() Debabrata Banerjee
2012-06-21 19:35 ` Josh Hunt
2012-06-21 20:27 ` Eric Dumazet
2012-06-21 21:50 ` Alexey Kuznetsov
2012-06-22 3:34 ` Gao feng
2012-06-22 6:49 ` Josh Hunt
2012-06-22 8:29 ` Eric Dumazet
2012-06-22 13:44 ` Josh Hunt
2012-06-22 18:13 ` Eric Dumazet [this message]
2012-06-22 21:12 ` Debabrata Banerjee
2012-06-23 0:02 ` David Miller
2012-06-23 5:37 ` Eric Dumazet
2012-06-23 20:55 ` Alexey Kuznetsov
2012-06-23 23:02 ` David Miller
2012-06-25 22:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340388785.4604.11442.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dbavatar@gmail.com \
--cc=jmorris@namei.org \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox