From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: alexander.h.duyck@intel.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, edumazet@google.com
Subject: Re: [PATCH] ipv4: Add sysctl knob to control early socket demux
Date: Sat, 23 Jun 2012 07:45:26 +0200 [thread overview]
Message-ID: <1340430326.4604.11946.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120622.171509.1112294083000632011.davem@davemloft.net>
On Fri, 2012-06-22 at 17:15 -0700, David Miller wrote:
> I applied this for now, making a minor change to move the local
> variables down into the new basic block you created.
>
Hmm, sorry to come late, but you left NET_IPV4_EARLY_DEMUX=126 sysctl,
while this is deprecated way...
> There has got to be a way to make this really cheap. At the very
> least we can have the GRO code store away the ports and therefore
> allow us to just do a direct call to try and demux the socket. Thus,
> we'd avoid all of pskb_may_pull() et al. packet validations, and
> packet header pointer calculations.
>
> Furthermore, we can reduce to overhead by making a special inet
> established hash demux that doesn't check for time-wait sockets,
> reducing the number of probes to 1 from 2.
The timewait hash chain is on the same cache line than established one.
And on a router, both chains are empty with a 99.999 % probability.
next prev parent reply other threads:[~2012-06-23 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 23:58 [PATCH] ipv4: Add sysctl knob to control early socket demux Alexander Duyck
2012-06-23 0:15 ` David Miller
2012-06-23 5:45 ` Eric Dumazet [this message]
2012-06-23 6:00 ` David Miller
2012-06-23 6:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340430326.4604.11946.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox