From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH 2/5] tcp: fix inet6_csk_route_req() for link-local addresses Date: Sun, 24 Jun 2012 09:37:33 +0200 Message-ID: <1340523453.23933.7.camel@edumazet-glaptop> References: <1340515324-2152-1-git-send-email-ncardwell@google.com> <1340515324-2152-2-git-send-email-ncardwell@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, Eric Dumazet , Tom Herbert To: Neal Cardwell Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:49318 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801Ab2FXHhg (ORCPT ); Sun, 24 Jun 2012 03:37:36 -0400 Received: by wgbdr13 with SMTP id dr13so3079909wgb.1 for ; Sun, 24 Jun 2012 00:37:35 -0700 (PDT) In-Reply-To: <1340515324-2152-2-git-send-email-ncardwell@google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2012-06-24 at 01:22 -0400, Neal Cardwell wrote: > Fix inet6_csk_route_req() to use as the flowi6_oif the treq->iif, > which is correctly fixed up in tcp_v6_conn_request() to handle the > case of link-local addresses. This brings it in line with the > tcp_v6_send_synack() code, which is already correctly using the > treq->iif in this way. > > Signed-off-by: Neal Cardwell > --- > net/ipv6/inet6_connection_sock.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c > index e6cee52..e23d354 100644 > --- a/net/ipv6/inet6_connection_sock.c > +++ b/net/ipv6/inet6_connection_sock.c > @@ -68,7 +68,7 @@ struct dst_entry *inet6_csk_route_req(struct sock *sk, > fl6.daddr = treq->rmt_addr; > final_p = fl6_update_dst(&fl6, np->opt, &final); > fl6.saddr = treq->loc_addr; > - fl6.flowi6_oif = sk->sk_bound_dev_if; > + fl6.flowi6_oif = treq->iif; > fl6.flowi6_mark = sk->sk_mark; > fl6.fl6_dport = inet_rsk(req)->rmt_port; > fl6.fl6_sport = inet_rsk(req)->loc_port; Acked-by: Eric Dumazet