From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: eilong@broadcom.com, "Yuval Mintz" <yuvalmin@broadcom.com>
Subject: [RFC net-next (v2) 01/14] net-next: Add netif_get_num_default_rss_queues
Date: Mon, 25 Jun 2012 14:45:32 +0300 [thread overview]
Message-ID: <1340624745-8650-2-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1340624745-8650-1-git-send-email-yuvalmin@broadcom.com>
Most multi-queue networking driver consider the number of online cpus when
configuring RSS queues.
This patch adds a wrapper to the number of cpus, setting an upper limit on the
number of cpus a driver should consider (by default) when allocating resources
for his queues.
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
include/linux/netdevice.h | 3 +++
net/core/dev.c | 11 +++++++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 2c2ecea..ab0251d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2119,6 +2119,9 @@ static inline int netif_copy_real_num_queues(struct net_device *to_dev,
#endif
}
+#define DEFAULT_MAX_NUM_RSS_QUEUES (8)
+extern int netif_get_num_default_rss_queues(void);
+
/* Use this variant when it is known for sure that it
* is executing from hardware interrupt context or with hardware interrupts
* disabled.
diff --git a/net/core/dev.c b/net/core/dev.c
index 57c4f9b..caae49c 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1793,6 +1793,17 @@ int netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
EXPORT_SYMBOL(netif_set_real_num_rx_queues);
#endif
+/* netif_get_num_default_rss_queues - default number of RSS queues
+ *
+ * This routine should set an upper limit on the number of RSS queues
+ * used by default by multiqueue devices.
+ */
+int netif_get_num_default_rss_queues()
+{
+ return min_t(int, DEFAULT_MAX_NUM_RSS_QUEUES, num_online_cpus());
+}
+EXPORT_SYMBOL(netif_get_num_default_rss_queues);
+
static inline void __netif_reschedule(struct Qdisc *q)
{
struct softnet_data *sd;
--
1.7.9.rc2
next prev parent reply other threads:[~2012-06-25 11:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 11:45 [RFC net-next (v2) 00/14] default maximal number of RSS queues in mq drivers Yuval Mintz
2012-06-25 11:45 ` Yuval Mintz [this message]
2012-06-25 11:45 ` [RFC net-next (v2) 02/14] mlx4: set maximal number of default RSS queues Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 03/14] vxge: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 04/14] qlge: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 05/14] cxgb3: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 06/14] cxgb4: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 07/14] myri10ge: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 08/14] tg3: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 09/14] bnx2: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 10/14] bnx2x: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 11/14] igb: " Yuval Mintz
2012-06-25 17:31 ` Vick, Matthew
2012-06-25 18:20 ` Eilon Greenstein
2012-06-25 18:38 ` Ben Hutchings
2012-06-25 11:45 ` [RFC net-next (v2) 12/14] ixgbe: " Yuval Mintz
2012-06-25 15:44 ` Alexander Duyck
2012-06-25 17:53 ` Eilon Greenstein
2012-06-25 18:38 ` Alexander Duyck
2012-06-25 18:44 ` Ben Hutchings
2012-06-25 21:03 ` Alexander Duyck
2012-06-26 11:08 ` Yuval Mintz
2012-06-26 15:55 ` Alexander Duyck
2012-06-26 18:23 ` Eilon Greenstein
2012-06-25 11:45 ` [RFC net-next (v2) 13/14] be2net: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 14/14] ixgbevf: " Yuval Mintz
2012-06-25 15:45 ` Alexander Duyck
2012-06-25 15:53 ` Eilon Greenstein
2012-06-25 16:33 ` Alexander Duyck
2012-06-25 18:28 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340624745-8650-2-git-send-email-yuvalmin@broadcom.com \
--to=yuvalmin@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).