From: Eric Dumazet <eric.dumazet@gmail.com>
To: Menny_Hamburger@Dell.com
Cc: netdev@vger.kernel.org
Subject: RE: [PATCH] net-next: ipv6: ndisc: allocate a ndisc socket per inet6_dev
Date: Mon, 25 Jun 2012 14:02:37 +0200 [thread overview]
Message-ID: <1340625757.10893.40.camel@edumazet-glaptop> (raw)
In-Reply-To: <D8C50530D6022F40A817A35C40CC06A70B34E34DA7@DUBX7MCDUB01.EMEA.DELL.COM>
On Mon, 2012-06-25 at 12:08 +0100, Menny_Hamburger@Dell.com wrote:
> I'm sorry for not responding on your post.
...
> I really want to understand how this fixes our problem.
> This fix will make the skb allocations succeed, but what mechanism releases the stuck socket associated with the bad device?
There is no stuck socket, I don't know why you believe this.
And I don't want to spend time writing a changelog if the patch doesn't
solve the problem, especially knowing you didn't even test it.
net/ipv4/arp.c arp_create() doesn't use a 'global socket' to attach skbs
on a socket.
This kind of protection makes sense for UDP / ICMP sockets, not for ARP
or ND resolution.
If you don't understand my patch, don't post your own, thats really lost
time for everyone.
We don't want adding yet another per device stuff for ipv6.
We already have too big memory footprint.
Once I am sure patch fixes the problem, I'll make an official submission
with all credits and changelog.
prev parent reply other threads:[~2012-06-25 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 10:26 [PATCH] net-next: ipv6: ndisc: allocate a ndisc socket per inet6_dev Menny_Hamburger
2012-06-25 10:41 ` Eric Dumazet
2012-06-25 11:08 ` Menny_Hamburger
2012-06-25 12:02 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340625757.10893.40.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=Menny_Hamburger@Dell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox