From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eilon Greenstein" Subject: Re: [RFC net-next (v2) 14/14] ixgbevf: set maximal number of default RSS queues Date: Mon, 25 Jun 2012 18:53:11 +0300 Message-ID: <1340639591.2486.25.camel@lb-tlvb-eilong.il.broadcom.com> References: <1340624745-8650-1-git-send-email-yuvalmin@broadcom.com> <1340624745-8650-15-git-send-email-yuvalmin@broadcom.com> <4FE88794.9090704@intel.com> Reply-To: eilong@broadcom.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "Yuval Mintz" , davem@davemloft.net, netdev@vger.kernel.org, "Jeff Kirsher" , "Greg Rose" To: "Alexander Duyck" Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:4973 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757158Ab2FYPxU (ORCPT ); Mon, 25 Jun 2012 11:53:20 -0400 In-Reply-To: <4FE88794.9090704@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2012-06-25 at 08:45 -0700, Alexander Duyck wrote: > On 06/25/2012 04:45 AM, Yuval Mintz wrote: > > Signed-off-by: Yuval Mintz > > Signed-off-by: Eilon Greenstein > > > > Cc: Jeff Kirsher > > Cc: Alexander Duyck > > Cc: Greg Rose > > --- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > > index f69ec42..7889644 100644 > > --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > > +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > > @@ -2023,7 +2023,7 @@ static int ixgbevf_set_interrupt_capability(struct ixgbevf_adapter *adapter) > > * (roughly) twice the number of vectors as there are CPU's. > > */ > > v_budget = min(adapter->num_rx_queues + adapter->num_tx_queues, > > - (int)(num_online_cpus() * 2)) + NON_Q_VECTORS; > > + netif_get_num_default_rss_queues() * 2) + NON_Q_VECTORS; > > > > /* A failure in MSI-X entry allocation isn't fatal, but it does > > * mean we disable MSI-X capabilities of the adapter. */ > I'm not even sure why you are bothering to alter this driver since it is > currently single queue only. Alex, Can you please explain the logic behind these lines in the current implementation? v_budget = min(adapter->num_rx_queues + adapter->num_tx_queues, (int)(num_online_cpus() * 2)) + NON_Q_VECTORS; It looks as if you were trying to be generic and support a future in which this driver will support more than a single queue - to be future ready, this RFC is replacing the usage of num_online_cpus with netif_get_num_default_rss_queues. Are you suggesting to remove these lines all together? Keeping this minimum function with only the num_online_cpus does not seem right without considering also the new default value. Thanks, Eilon