From: Eldad Zack <eldad@fogrefinery.com>
To: netdev@vger.kernel.org
Cc: Eldad Zack <eldad@fogrefinery.com>
Subject: [PATCH RFC 0/8] LLDP implementation for Linux
Date: Mon, 25 Jun 2012 20:28:12 +0200 [thread overview]
Message-ID: <1340648900-6547-1-git-send-email-eldad@fogrefinery.com> (raw)
Hi all,
This series of patches provides a partial LLDP (IEEE Std 802.1ab)
implementation.
I'd really appreciate a review of it.
LLDP is a simple discovery protocol which advertises the identification and
other info (such as MTU or capabilities) of device on the link. It can also
help debug misconfigurations on the link layer (wrong MTU, wrong VLAN).
Some notes/questions:
* Applies against net-next and mainline.
* Included in this series is only LLDP output code.
This is not an issue since input and output are decoupled in LLDP anyway.
I'm working on the input code as well and will post it at some point in the
future.
* Sysctl is used to do (some) configuration. This is done globally right now.
Before I add per-device sysctls: is it at all appropriate to use sysctl
here?
* By default, transmission is suppressed. To arm it, set
/proc/sys/net/lldp/lldp_op_mode
to 1.
* I've tested it on x86_64 and (qemu'd) x86.
* I've tested it on my machine and it works with Ethernet and WLAN.
* The last patch ("8021q/vlan: process NETDEV_GOING_DOWN") is needed
to be able to send shutdown PDU on VLAN interfaces, but has otherwise
no effect.
* Is there a better way to deal with 16-bit endianness other than masking and
shifting, when one field is more than a byte long (in this case 7/9)?
* I usually only work on it on weekends, so I might be slow in responding back.
Thanks in advance if you're taking the time to review it or test it!
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
next reply other threads:[~2012-06-25 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 18:28 Eldad Zack [this message]
2012-06-25 18:28 ` [PATCH 1/8] if_ether.h: Add LLDP ethertype Eldad Zack
2012-06-25 18:48 ` Eldad Zack
2012-06-25 18:28 ` [PATCH 2/8] LLDP: Header Eldad Zack
2012-06-25 18:28 ` [PATCH 3/8] LLDP: Sysctl interface Eldad Zack
2012-06-25 18:28 ` [PATCH 4/8] LLDP: PDU-handling routines Eldad Zack
2012-06-25 18:28 ` [PATCH 5/8] LLDP: Output routines Eldad Zack
2012-06-25 18:28 ` [PATCH 6/8] LLDP: Core routines Eldad Zack
2012-06-25 18:28 ` [PATCH 7/8] LLDP: Kconfig and Makefile Eldad Zack
2012-06-25 18:28 ` [PATCH 8/8] 8021q/vlan: process NETDEV_GOING_DOWN Eldad Zack
2012-06-25 18:33 ` [PATCH RFC 0/8] LLDP implementation for Linux Eldad Zack
2012-06-25 18:54 ` Stephen Hemminger
2012-06-25 20:05 ` Eldad Zack
2012-06-25 19:00 ` John Fastabend
2012-06-25 20:21 ` Eldad Zack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340648900-6547-1-git-send-email-eldad@fogrefinery.com \
--to=eldad@fogrefinery.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox