From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Remove unnecessary code from rt_check_expire().
Date: Tue, 26 Jun 2012 09:39:58 +0200 [thread overview]
Message-ID: <1340696398.10893.209.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120626.002124.2220875506847485306.davem@davemloft.net>
On Tue, 2012-06-26 at 00:21 -0700, David Miller wrote:
> IPv4 routing cache entries no longer use dst->expires, because the
> metrics, PMTU, and redirect information are stored in the inetpeer
> cache.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>
> Eric, when you did commit 9f28a2fc0bd77511f649c0a788c7bf9a5fd04edb
> (ipv4: reintroduce route cache garbage collector) do you remember
> if the thing we needed was the real expiry or both the
> rt_is_expired() and the rt_may_expire() cases?
>
> I really want to remove rt_may_expire() from this conditional because
> it results in absolutely stupid behavior. If your system is idle
> for 5 minutes, all of your input routing cache entries are purged.
Hmm, after a DDOS, purging all those routing cache entries in 5 minutes
is good to recover some Mbytes of kernel memory.
next prev parent reply other threads:[~2012-06-26 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 7:21 [PATCH] ipv4: Remove unnecessary code from rt_check_expire() David Miller
2012-06-26 7:39 ` Eric Dumazet [this message]
2012-06-26 7:46 ` David Miller
2012-06-26 7:58 ` Eric Dumazet
2012-06-26 8:23 ` Eric Dumazet
2012-06-26 8:37 ` David Miller
2012-06-26 8:46 ` Eric Dumazet
2012-06-26 8:56 ` David Miller
2012-06-26 9:11 ` Eric Dumazet
2012-06-26 9:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340696398.10893.209.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox