From: Vinson Lee <vlee@twitter.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, <mirq-linux@rere.qmqm.pl>,
Jiri Pirko <jpirko@redhat.com>, Tom Herbert <therbert@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vinson Lee <vlee@twitter.com>,
David Mackey <tdmackey@twitter.com>
Subject: [PATCH] net: Downgrade CAP_SYS_MODULE deprecated message from error to warning.
Date: Wed, 27 Jun 2012 17:32:07 -0700 [thread overview]
Message-ID: <1340843527-9962-1-git-send-email-vlee@twitter.com> (raw)
Make logging level consistent with other deprecation messages in net
subsystem.
Signed-off-by: Vinson Lee <vlee@twitter.com>
Cc: David Mackey <tdmackey@twitter.com>
---
net/core/dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index cd09819..b19a361 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1136,8 +1136,8 @@ void dev_load(struct net *net, const char *name)
no_module = request_module("netdev-%s", name);
if (no_module && capable(CAP_SYS_MODULE)) {
if (!request_module("%s", name))
- pr_err("Loading kernel module for a network device with CAP_SYS_MODULE (deprecated). Use CAP_NET_ADMIN and alias netdev-%s instead.\n",
- name);
+ pr_warn("Loading kernel module for a network device with CAP_SYS_MODULE (deprecated). Use CAP_NET_ADMIN and alias netdev-%s instead.\n",
+ name);
}
}
EXPORT_SYMBOL(dev_load);
--
1.7.9.5
next reply other threads:[~2012-06-28 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 0:32 Vinson Lee [this message]
2012-06-28 23:55 ` [PATCH] net: Downgrade CAP_SYS_MODULE deprecated message from error to warning David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340843527-9962-1-git-send-email-vlee@twitter.com \
--to=vlee@twitter.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=tdmackey@twitter.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).