From: Eric Dumazet <eric.dumazet@gmail.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Jiri Pirko <jpirko@redhat.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Sergey Lapin <slapin@ossfans.org>,
Johannes Berg <johannes@sipsolutions.net>,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] net: Use NLMSG_DEFAULT_SIZE in combination with nlmsg_new()
Date: Thu, 28 Jun 2012 16:55:49 +0200 [thread overview]
Message-ID: <1340895349.13187.105.camel@edumazet-glaptop> (raw)
In-Reply-To: <caecbaa2f181c17908fbd61264e1acb9c5cb1fe1.1340891841.git.tgraf@suug.ch>
On Thu, 2012-06-28 at 15:57 +0200, Thomas Graf wrote:
> Using NLMSG_GOODSIZE results in multiple pages being used as
> nlmsg_new() will automatically add the size of the netlink
> header to the payload thus exceeding the page limit.
On the other hand, this limits to 3776 bytes for each recvmsg() call.
Maybe this can add a regression if one of the file needed to store more
than 3776 bytes in the answer ?
For GFP_KERNEL allocations, I am not sure we really need to limit to
order-0 pages...
Unless you can point a real bug, this patch is not for net tree, but
net-next.
next prev parent reply other threads:[~2012-06-28 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 13:57 [PATCH] net: Use NLMSG_DEFAULT_SIZE in combination with nlmsg_new() Thomas Graf
2012-06-28 14:04 ` Jiri Pirko
2012-06-28 14:55 ` Eric Dumazet [this message]
2012-06-28 17:10 ` Thomas Graf
2012-06-29 0:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340895349.13187.105.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=aloisio.almeida@openbossa.org \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=jpirko@redhat.com \
--cc=lauro.venancio@openbossa.org \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=slapin@ossfans.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox