From: Rostislav Lisovy <lisovy@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
lartc@vger.kernel.org, pisa@cmp.felk.cvut.cz,
sojkam1@fel.cvut.cz
Subject: Re: [PATCH net-next] em_canid: Ematch rule to match CAN frames according to their CAN IDs
Date: Thu, 28 Jun 2012 19:02:38 +0200 [thread overview]
Message-ID: <1340902958.9286.1.camel@lolumad> (raw)
In-Reply-To: <4FEC87E8.1030405@hartkopp.net>
On Thu, 2012-06-28 at 18:35 +0200, Oliver Hartkopp wrote:
>
> What about
>
> match = (test_bit(can_id, cm->match_sff))?1:0;
>
> and working with "1" and "0" all the time instead of the final correction to
> the return values at the end of the function?
I agree;
Regards;
Rostislav
prev parent reply other threads:[~2012-06-28 17:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 12:22 [PATCH net-next] em_canid: Ematch rule to match CAN frames according to their CAN IDs Rostislav Lisovy
2012-06-26 20:07 ` Oliver Hartkopp
2012-06-26 21:32 ` Thomas Graf
2012-06-27 9:33 ` Kurt Van Dijck
2012-06-28 15:35 ` Rostislav Lisovy
2012-06-28 13:35 ` Rostislav Lisovy
2012-06-28 16:35 ` Oliver Hartkopp
2012-06-28 17:02 ` Rostislav Lisovy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340902958.9286.1.camel@lolumad \
--to=lisovy@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=lartc@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pisa@cmp.felk.cvut.cz \
--cc=socketcan@hartkopp.net \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).